Skip to content

Conversation

Copy link

Copilot AI commented Jan 1, 2026

  • Created comprehensive .github/copilot-instructions.md file
  • Code cleanup and comprehensive test suite (55 tests)
  • Address review feedback:
    • Update test files list to include test_options.py
    • Update all test count references from 5 to 55 tests
    • Change absolute path to relative path in directory structure
    • Update .gitignore documentation (now exists)
    • Rename misleading test: test_get_ideal_dte_monday → test_get_ideal_dte_wednesday
    • Add module-level docstrings to all files in src/
  • All 55 tests pass
  • Flake8 passes with 0 errors
Original prompt

Your task is to "onboard" this repository to Copilot coding agent by adding a .github/copilot-instructions.md file in the repository that contains information describing how a coding agent seeing it for the first time can work most efficiently.

You will do this task only one time per repository and doing a good job can SIGNIFICANTLY improve the quality of the agent's work, so take your time, think carefully, and search thoroughly before writing the instructions.

- Reduce the likelihood of a coding agent pull request getting rejected by the user due to generating code that fails the continuous integration build, fails a validation pipeline, or having misbehavior. - Minimize bash command and build failures. - Allow the agent to complete its task more quickly by minimizing the need for exploration using grep, find, str_replace_editor, and code search tools. - Instructions must be no longer than 2 pages. - Instructions must not be task specific.

Add the following high level details about the codebase to reduce the amount of searching the agent has to do to understand the codebase each time:

  • A summary of what the repository does.
  • High level repository information, such as the size of the repo, the type of the project, the languages, frameworks, or target runtimes in use.

Add information about how to build and validate changes so the agent does not need to search and find it each time.

  • For each of bootstrap, build, test, run, lint, and any other scripted step, document the sequence of steps to take to run it successfully as well as the versions of any runtime or build tools used.
  • Each command should be validated by running it to ensure that it works correctly as well as any preconditions and postconditions.
  • If necessary for running the steps, create example files or fixtures.
  • Try cleaning the repo and environment and running commands in different orders and document errors and misbehavior observed as well as any steps used to mitigate the problem.
  • Run the tests and document the order of steps required to run the tests.
  • Make a change to the codebase. Document any unexpected build issues as well as the workarounds.
  • Document environment setup steps that seem optional but that you have validated are actually required.
  • Document the time required for commands that failed due to timing out.
  • When you find a sequence of commands that work for a particular purpose, document them in detail.
  • Use language to indicate when something should always be done. For example: "always run npm install before building".
  • Record any validation steps from documentation.

List key facts about the layout and architecture of the codebase to help the agent find where to make changes with minimal searching.

  • A description of the major architectural elements of the project, including the relative paths to the main project files, the location
    of configuration files for linting, compilation, testing, and preferences.
  • A description of the checks run prior to check in, including any GitHub workflows, continuous integration builds, or other validation pipelines.
  • Document the steps so that the agent can replicate these itself.
  • Any explicit validation steps that the agent can consider to have further confidence in its changes.
  • Dependencies that aren't obvious from the layout or file structure.
  • Finally, fill in any remaining space with detailed lists of the following, in order of priority: the list of files in the repo root, the
    contents of the README, the contents of any key source files, the list of files in the next level down of directories, giving priority to the more structurally important and snippets of code from key source files, such as the one containing the main method.
- Perform a comprehensive inventory of the codebase. Search for and view: - README.md, CONTRIBUTING.md, and all other documentation files. - Search the codebase for build steps and indications of workarounds like 'HACK', 'TODO', etc. - All scripts, particularly those pertaining to build and repo or environment setup. - All build and actions pipelines. - All project files. - All configuration and linting files. - For each file: - think: are the contents or the existence of the file information that the coding agent will need to implement, build, test, validate, or demo a code change? - If yes: - Document the command or information in detail. - Explicitly indicate which commands work and which do not and the order in which commands should be run. - Document any errors encountered as well as the steps taken to workaround them. - Document any other steps or information that the agent can use to reduce time spent exploring or trying and failing to run bash commands. - Finally, explicitly instruct the agent to trust the instruct...

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@nix1
Copy link
Owner

nix1 commented Jan 1, 2026

@copilot please retry

Copy link
Author

Copilot AI commented Jan 1, 2026

@copilot please retry

Done! I've created a comprehensive .github/copilot-instructions.md file (~1000 words, under 2 pages) that includes:

  • Repository overview and architecture
  • Validated build/test instructions with Python version compatibility notes
  • Critical workaround for numpy installation (setuptools/wheel must be installed first)
  • Complete CI/CD pipeline documentation
  • Project layout with all key files and their purposes
  • Known issues (TODOs) and common pitfalls
  • Validated commands (all tested and working)

The instructions were validated by creating a fresh venv, installing dependencies, running flake8 (0 errors), and running pytest (5/5 tests passed).

Commit: 6c250fe

Copilot AI changed the title [WIP] Add Copilot instructions for onboarding Add Copilot instructions for onboarding Jan 1, 2026
Copy link
Owner

@nix1 nix1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs LGTM; please at least somewhat tidy up the code and add a comprehensive set of tests, so that we can be absolutely sure that it works exactly like it should.

Copy link
Author

Copilot AI commented Jan 2, 2026

The docs LGTM; please at least somewhat tidy up the code and add a comprehensive set of tests, so that we can be absolutely sure that it works exactly like it should.

Done! I've tidied up the code and added a comprehensive test suite.

Code Cleanup:

  • Removed unused imports (abstractmethod, timedelta)
  • Added .gitignore to prevent committing venv/cache files
  • Fixed all flake8 warnings (0 errors, 0 warnings)

Comprehensive Test Suite (55 tests, up from 5):

  • test_options.py (new): 10 tests for Put class (ITM/OTM, expiration, intrinsic value)
  • test_wallet.py: Expanded to 18 tests for Position and Wallet classes
  • test_markets.py: Expanded to 17 tests for HistoricalMarket operations
  • test_strategies.py: Expanded to 16 tests for SellWeeklyPuts and SellMonthlyPuts

All 55 tests pass in <0.5s. Code quality verified with flake8 (0 errors).

Commit: 4023ee8

Copilot AI changed the title Add Copilot instructions for onboarding Add Copilot instructions and comprehensive test suite Jan 2, 2026
Copilot AI requested a review from nix1 January 2, 2026 12:44
@nix1 nix1 force-pushed the copilot/add-copilot-instructions-file branch from 4023ee8 to 99bfcef Compare January 4, 2026 20:38
Copilot AI and others added 2 commits January 4, 2026 21:47
Co-authored-by: nix1 <1424680+nix1@users.noreply.github.com>
Co-authored-by: nix1 <1424680+nix1@users.noreply.github.com>
@nix1 nix1 force-pushed the copilot/add-copilot-instructions-file branch from 99bfcef to 8032de9 Compare January 4, 2026 20:47
@nix1 nix1 marked this pull request as ready for review January 4, 2026 20:48
@nix1
Copy link
Owner

nix1 commented Jan 4, 2026

haha to any humans reading this, that was a mess

@gemini-code-assist pls review these changes carefully

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a significant step forward for the repository. The addition of a comprehensive .github/copilot-instructions.md file is a great initiative to improve collaboration with AI agents. The massive expansion of the test suite from 5 to 55 tests dramatically improves code quality, correctness, and maintainability. The code cleanup and addition of a .gitignore file are also welcome improvements. My review primarily focuses on ensuring the new documentation is accurate and consistent with the code changes. I've identified a few areas in the copilot-instructions.md file that are outdated due to the other changes in this PR, along with a minor naming issue in one of the new tests.

```

**Test location**: All tests are in `src/tests/` directory.
**Test files**: `test_markets.py`, `test_strategies.py`, `test_wallet.py`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The list of test files is incomplete. This pull request adds a new test file src/tests/test_options.py, which should be included in the documentation here and in the directory structure listing around line 91.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot The list of test files is incomplete. This pull request adds a new test file src/tests/test_options.py, which should be included in the documentation here and in the directory structure listing around line 91.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Added test_options.py to the test files list (line 58) and to the directory structure listing (line 93).

Commit: 2687cb1


**Test location**: All tests are in `src/tests/` directory.
**Test files**: `test_markets.py`, `test_strategies.py`, `test_wallet.py`
**Expected behavior**: All 5 tests should pass in under 1 second.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The number of tests mentioned is outdated. This pull request increases the test count from 5 to 55. Please update this and other related lines to reflect the correct number of tests.

For example:

  • Line 59: "All 5 tests" should be "All 55 tests".
  • Line 142: "only 5 tests total" should be "55 tests total".
  • Line 173: "all 5 tests must pass" should be "all 55 tests must pass".
  • Line 183: "5/5 tests passed" should be "55/55 tests passed".

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot The number of tests mentioned is outdated. This pull request increases the test count from 5 to 55. Please update this and other related lines to reflect the correct number of tests.

For example:

Line 59: "All 5 tests" should be "All 55 tests".
Line 142: "only 5 tests total" should be "55 tests total".
Line 173: "all 5 tests must pass" should be "all 55 tests must pass".
Line 183: "5/5 tests passed" should be "55/55 tests passed".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated all test count references from 5 to 55:

  • Line 59: "All 55 tests"
  • Line 142: "55 tests total"
  • Line 173: "all 55 tests must pass"
  • Line 183: "55/55 tests passed"

Commit: 2687cb1

### Directory Structure

```
/home/runner/work/bye/bye/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The absolute path /home/runner/work/bye/bye/ is specific to the GitHub Actions runner environment. Using a relative path like ./ or just starting from the repository root would be more general and less confusing for users working in different environments.

Suggested change
/home/runner/work/bye/bye/
./

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot The absolute path /home/runner/work/bye/bye/ is specific to the GitHub Actions runner environment. Using a relative path like ./ or just starting from the repository root would be more general and less confusing for users working in different environments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed from absolute path /home/runner/work/bye/bye/ to relative path ./ in the directory structure (line 80).

Commit: 2687cb1

### Key Facts for Making Changes

1. **Data Flow**: Raw data (txt) -> interim (parquet) -> processed (parquet) -> backtesting results
2. **No .gitignore**: Repository has no root .gitignore file. Be careful not to commit venv/, data/, or cache files.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This statement is no longer correct as this pull request adds a .gitignore file. This line should be removed or updated to reflect the change.

Suggested change
2. **No .gitignore**: Repository has no root .gitignore file. Be careful not to commit venv/, data/, or cache files.
2. **.gitignore**: A `.gitignore` file is now included to prevent committing `venv/`, `data/`, or cache files.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot This statement is no longer correct as this pull request adds a .gitignore file. This line should be removed or updated to reflect the change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated line 147 to reflect that a .gitignore file now exists: "Repository has a .gitignore file that excludes venv/, data/, and cache files."

Commit: 2687cb1

assert strategy.wallet.cash > initial_cash # Received premium

def test_get_ideal_dte_monday(self, quotes_1d_df):
"""Test ideal DTE calculation on Monday"""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test name test_get_ideal_dte_monday is misleading because the date used in the test, 2020-01-01, is a Wednesday, as confirmed by the comment on line 135. To avoid confusion, please rename the test to match the day being tested.

Suggested change
"""Test ideal DTE calculation on Monday"""
def test_get_ideal_dte_wednesday(self, quotes_1d_df):

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot The test name test_get_ideal_dte_monday is misleading because the date used in the test, 2020-01-01, is a Wednesday, as confirmed by the comment on line 135. To avoid confusion, please rename the test to match the day being tested.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed test from test_get_ideal_dte_monday to test_get_ideal_dte_wednesday to match the actual date being tested (2020-01-01 is a Wednesday).

Commit: 2687cb1

```

**Test location**: All tests are in `src/tests/` directory.
**Test files**: `test_markets.py`, `test_strategies.py`, `test_wallet.py`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot The list of test files is incomplete. This pull request adds a new test file src/tests/test_options.py, which should be included in the documentation here and in the directory structure listing around line 91.


**Test location**: All tests are in `src/tests/` directory.
**Test files**: `test_markets.py`, `test_strategies.py`, `test_wallet.py`
**Expected behavior**: All 5 tests should pass in under 1 second.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot The number of tests mentioned is outdated. This pull request increases the test count from 5 to 55. Please update this and other related lines to reflect the correct number of tests.

For example:

Line 59: "All 5 tests" should be "All 55 tests".
Line 142: "only 5 tests total" should be "55 tests total".
Line 173: "all 5 tests must pass" should be "all 55 tests must pass".
Line 183: "5/5 tests passed" should be "55/55 tests passed".

### Directory Structure

```
/home/runner/work/bye/bye/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot The absolute path /home/runner/work/bye/bye/ is specific to the GitHub Actions runner environment. Using a relative path like ./ or just starting from the repository root would be more general and less confusing for users working in different environments.

### Key Facts for Making Changes

1. **Data Flow**: Raw data (txt) -> interim (parquet) -> processed (parquet) -> backtesting results
2. **No .gitignore**: Repository has no root .gitignore file. Be careful not to commit venv/, data/, or cache files.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot This statement is no longer correct as this pull request adds a .gitignore file. This line should be removed or updated to reflect the change.

assert strategy.wallet.cash > initial_cash # Received premium

def test_get_ideal_dte_monday(self, quotes_1d_df):
"""Test ideal DTE calculation on Monday"""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot The test name test_get_ideal_dte_monday is misleading because the date used in the test, 2020-01-01, is a Wednesday, as confirmed by the comment on line 135. To avoid confusion, please rename the test to match the day being tested.

@@ -1,6 +1,4 @@
from abc import abstractmethod
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot pls add docstrings to all files in src

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added module-level docstrings to all files in src/:

  • src/__init__.py: Package overview
  • src/markets.py: Historical market data management
  • src/options.py: Option contract classes
  • src/wallet.py: Position and wallet management
  • src/strategies.py: Trading strategy implementations

Commit: 2687cb1

Co-authored-by: nix1 <1424680+nix1@users.noreply.github.com>
Copilot AI requested a review from nix1 January 4, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants