-
-
Notifications
You must be signed in to change notification settings - Fork 363
plugins/substitute: added plugin #4010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for the quick response! I have changed the code as per your suggestions :) |
HeitorAugustoLN
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else LGTM
|
Good catch, changed it so that aligns with that now. |
|
Fixed the ... of the inputs, the other comment was already resolved in an older commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think you might need to squash your commits to:
maintainers: add fwastring
plugins/substitute: init
|
Thank you, I will do that. How do I request another review to be able to merge? |
|
Since you are not a maintainer yet, you can't request reviews, but I will request for you |
|
Could you have a look at this? @GaetanLepage |
This still needs to be done. Otherwise, LGTM. |
|
I think I squashed the commits now @MattSturgeon |
Sorry for the misunderstanding. There needs to be two commits:
Currently, there is only a single one. |
| { | ||
| lib, | ||
| ... | ||
| }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| { | |
| lib, | |
| ... | |
| }: | |
| { lib, ... }: |
nit
b54fceb to
6f4237f
Compare
|
Squashed to two commits now @GaetanLepage 👍🏻 |
Commits are in the wrong order. The
Simply drop a few options. I don't think that they are interdependent, are they? |
plugins/substitute: removed options and used nested plugins/substitute: changed example plugins/substitute: remove __raw plugins/substitute: Fixed failing test plugins/substitute: removedplugins/substitute: init removed
|
There we go, trimmed down the |
GaetanLepage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the corrections @fwastring!
Added support for substitute.nvim.
Added tests and plugin support, and myself as a maintainer.