Immutable value objects for dispatch results #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marks the classes as `readonly` and makes use of constructor property promotion. The reason for this change is to allow consumers to safely create immutable results that can be used in tests. Previously, without the constructor, consumers using SA tooling could not set the readonly properties after construction.
Collaborator
|
I need to investigate this one... when I introduced the result object I saw negative impact on the benchmark using the constructor... Out of curiosity, why do you need to instantiate this? |
Author
|
The main reason for this patch is so I can instantiate result values without writing to I ran the benchmarks locally with a retry threshold of 5 with:
Looks to me like that's not an insignificant performance penalty. I wonder if a static/named constructor might improve things 🤔 master vs current
|
Author
|
Update: I tried dropping the constructor and moving instantiation to a static factory method like: /**
* @param array<string, string> $variables
* @param ExtraParameters $extraParameters
*/
public static function new(
mixed $handler,
array $variables = [],
array $extraParameters = [],
): self {
$instance = new self();
$instance->handler = $handler;
$instance->variables = $variables;
$instance->extraParameters = $extraParameters;
return $instance;
}This had little effect on the performance penalty, also removing Please feel free to close 👍 |
Collaborator
|
It's related to the additional calls happening at opcode level, which is also why Doctrine hydrates objects using serialisation 😅 I'll have a look at the patch in the adapter once I'm on a laptop 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on the Mezzio adapter for FastRoute, I noticed it's "impossible" to create dispatch results without writing to soft
@readonlyproperties.Psalm hates that… so I took the liberty of dropping PHP 8.1, and making the results
readonlyclasses with constructors.Mainly this is useful in testing…
I've also added 8.5 to CI
Sorry if this patch is doing too much 😬