Skip to content

Conversation

@bensmiley
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files          15       15           
  Lines         548      548           
  Branches       91       91           
=======================================
  Hits          481      481           
  Misses         55       55           
  Partials       12       12
Impacted Files Coverage Δ
lib/dictionary.js 87.98% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b80e6d...0946112. Read the comment docs.

@benlieb
Copy link

benlieb commented Oct 5, 2024

I'm running into this issue with Chrome Extension V3 as well:

image

It's blocking my whole extension from running now. Is there a workaround for this?

@bensmiley

@benlieb
Copy link

benlieb commented Oct 5, 2024

@nieldlr It looks like this is now a critical issue now. Any possibility you'll merge this or should I fork? I'd rather not fork, but my PR from 2020 also still hasn't been responded to. #60

Are you open to adding maintainers?

@nieldlr nieldlr merged commit 8d024fc into nieldlr:master Oct 6, 2024
@nieldlr
Copy link
Owner

nieldlr commented Oct 8, 2024

Hi @benlieb,

sorry about this. I've haven't been focused on this for a while, but I definitely don't want it to be a blocker. I've merged this fix. Do you need this update published to npm as well?

I'm not currently looking for maintainers. But I also don't want to a bottleneck here. I'll reflect on this a bit and potentially find a way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants