Skip to content

Update first release procedure #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maxulysse wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Update first release procedure #2640

maxulysse wants to merge 11 commits into from

Conversation

@maxulysse
Copy link
Member

@maxulysse maxulysse commented Jul 10, 2024 •
edited by nf-core-bot
Loading

@netlify /docs/tutorials/adding_a_pipeline/first_release

@netlify
Copy link

netlify bot commented Jul 10, 2024 •
edited
Loading

✅ Deploy Preview for nf-core-main-site ready!

Name Link
🔨 Latest commit 45611ca
🔍 Latest deploy log https://app.netlify.com/projects/nf-core-main-site/deploys/6936b268473fff00087abf62
😎 Deploy Preview https://deploy-preview-2640--nf-core-main-site.netlify.app/docs/tutorials/adding_a_pipeline/first_release
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@maxulysse
Copy link
Member Author

maxulysse commented Jul 10, 2024

@nf-core-bot fix linting pretty please 🙏

@maxulysse maxulysse changed the title Update first_release.md Update first release procedure Jul 10, 2024
@mahesh-panchal
Copy link
Member

mahesh-panchal commented Jul 10, 2024

So if I understand this correctly, the PR shows you the differences to the latest template release which may not be in master, making sure you're only reviewing changes between your pipeline and template instead of the changes between the old version of the template and new version of the template and pipeline changes?

@maxulysse @jfy133
Update sites/docs/src/content/docs/tutorials/adding_a_pipeline/first_…
a7ae992 
…release.md

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@ewels
Copy link
Member

ewels commented Jul 12, 2024

Has anyone checked this process to make sure that it definitely works, with merge conflicts etc?

@mashehu
Copy link
Contributor

mashehu commented Jun 9, 2025

any updates here @maxulysse?

@maxulysse
Copy link
Member Author

maxulysse commented Jun 9, 2025

any updates here @maxulysse?

I totally forgot about it

@maxulysse
Copy link
Member Author

maxulysse commented Jun 9, 2025

Let me solve the merge conflicts

@netlify
Copy link

netlify bot commented Jun 9, 2025 •
edited
Loading

✅ Deploy Preview for nf-core-docs ready!

Name Link
🔨 Latest commit 45611ca
🔍 Latest deploy log https://app.netlify.com/projects/nf-core-docs/deploys/6936b268041d5f0008fc7b3c
😎 Deploy Preview https://deploy-preview-2640--nf-core-docs.netlify.app/docs/tutorials/adding_a_pipeline/first_release
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

maxulysse and others added 2 commits June 10, 2025 10:19
@maxulysse @christopher-hakkaart
Apply suggestions from code review
88b8e79 
Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io>
@mashehu
Merge branch 'main' into new_procedure
59d4715
@christopher-hakkaart
Copy link
Member

christopher-hakkaart commented Aug 6, 2025

I can't remember where this got to, added some language suggestions anyway.

@mashehu @christopher-hakkaart
Apply suggestions from code review
dc965f9 
Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io>
christopher-hakkaart
christopher-hakkaart approved these changes Nov 16, 2025
View reviewed changes
Copy link
Member

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the text here, I'm not sure if someone more technical wanted to chime in, but LGTM

mashehu
mashehu reviewed Nov 17, 2025
View reviewed changes
sites/docs/src/content/docs/tutorials/adding_a_pipeline/first_release.md
To start a review for the initial release of your pipeline:

1. Make a pull-request from the `dev` branch to `master` on the nf-core fork. This is a
1. Create a new branch named `TEMPLATE_<TOOLS_VERSION>`, based on the version of `TEMPLATE` from the `dev `branch you plan to merge into `master`.
Copy link
Contributor

@mashehu mashehu Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never create this branch, I just make a the PR directly to the TEMPLATE, why would I need the versioned branch, @maxulysse ?

@mashehu
Copy link
Contributor

mashehu commented Dec 8, 2025

@nf-core-bot fix linting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashehu mashehu mashehu left review comments

@jfy133 jfy133 jfy133 left review comments

@christopher-hakkaart christopher-hakkaart christopher-hakkaart approved these changes

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@maxulysse @mahesh-panchal @ewels @mashehu @christopher-hakkaart @jfy133 @nf-core-bot