fix: use tag rather than timestamp in dataset changelog headings #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using a timestamp in changelog headings, e.g. `2024-02-16T04:00:32Z`, let's use version tag, which is a safe representation of a timestamp, e.g. `2024-02-16--04-00-32Z`. Side-by-side for comparison: ``` 2024-02-16T04:00:32Z 2024-02-16--04-00-32Z ``` This will make the representation consistent across `CHANGELOG.md`, `index.json`, `pathogen.json`, git commit text andgit tags, filesystem paths, CLI display and args, etc. Notable exception is web UI, which decides how to represent dates in on its own to make it look friendlier for less technical users.
ivan-aksamentov
deployed
to
refs/pull/176/merge
GitHub Actions
Active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using a timestamp in changelog headings, e.g.
2024-02-16T04:00:32Z, let's use version tag, which is a safe representation of a timestamp, e.g.2024-02-16--04-00-32Z.Side-by-side for comparison:
This will make the representation consistent across
CHANGELOG.md,index.json,pathogen.json, git commit text andgit tags, filesystem paths, CLI display and args, etc.Notable exception is web UI, which decides how to represent dates in on its own to make it look friendlier for less technical users.