Remove redundant include strains #843
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes older references from the list of strains to force include in analyses. We use the single Wuhan/Hu-1/2019 strains as the reference for alignment and time tree rooting, so the other two strains are not required. Importantly, these additional strains get used in proximity calculations with priority-based subsampling leading to the unexpected inclusion of contextual strains that look like these redundant root sequences. We try to avoid this problem in the proximity calculations by defining a list of strains to ignore [1], but this list only includes the strain used to root the time tree. Rather than updating this list to include more strains, we can just remove the strains from the include file. [1] https://github.com/nextstrain/ncov/blob/51ac8143761057c14de3841e46b82e08f7fef4b6/workflow/snakemake_rules/main_workflow.smk#L372
Defines a list of strains to ignore, including the two reference sequences we use for GISAID and GenBank builds and passes this list to the `ignore_seqs` parameter of the proximity calculations instead of the current build's root sequence alone.
cassiawag
reviewed
Jan 25, 2022
Collaborator
There was a problem hiding this comment.
I tested this out on ncov-kenya, and the proximity sequences & priority scores were as expected. Thanks @huddlej!
Contributor
Author
|
@rneher Does this look ok to you, too? This bit of the workflow is just complicated enough that I can imagine I'm missing something with this change... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Removes older references from the list of strains to force include in
analyses. We use the single Wuhan/Hu-1/2019 strains as the reference for
alignment and time tree rooting, so the other two strains are not
required. Importantly, these additional strains get used in proximity
calculations with priority-based subsampling leading to the unexpected
inclusion of contextual strains that look like these redundant root
sequences. We try to avoid this problem in the proximity calculations by
defining a list of strains to ignore, but this list only includes
the strain used to root the time tree. Rather than updating this list to
include more strains, we can just remove the strains from the include
file.
Testing