Add documentation of signaling messages #9407
Open
+386
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I guess that's replacing the todo here? |
Contributor
Author
Actually I think that this is something different. Because the internal signaling API would be the endpoint to send / receive messages through the API, isn't it? This PR includes the format of the messages, both for internal and external signaling. |
SystemKeeper
force-pushed
the
feature/noid/add-signaling-message-docs
branch
from
1101864 to
cdf6b83
Compare
Contributor
Author
|
nickvergessen
modified the milestones:
v18.0.0-beta.1,
💙 Next Beta (28),
💞 Next Major (29)
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
force-pushed
the
feature/noid/add-signaling-message-docs
branch
from
cdf6b83 to
76ba532
Compare
nickvergessen
modified the milestones:
v19.0.0-beta.3,
💞 Next Beta (29),
v19.0.0-beta.4
nickvergessen
modified the milestones:
v19.0.0-beta.5,
💞 Next RC (29),
💙 Next Major (30)
nickvergessen
added
feature: api 🛠️
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
…ment Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
feature/noid/add-signaling-message-docs
branch
from
76ba532 to
6f565ea
Compare
nickvergessen
modified the milestones:
v21.0.0-beta.2,
🌿 Next Beta (31),
v21.0.0-rc.1,
🪺 Next Major (32)
nickvergessen
modified the milestones:
v22.0.0-beta.2,
🪺 Next RC (32),
🍏 Next Major (33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a shameless copy of @danxuliu's work over at the android client, but I think we should have this documented here as well.
I only documented the field explicitly that had a comment on the android side before. There's room for improvements here for sure.
🏁 Checklist
docs/has been updated or is not required