-
Notifications
You must be signed in to change notification settings - Fork 18
feat: support multiple providers #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0a16060 to
ec9f3f6
Compare
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
ec9f3f6 to
87aaffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could you describe more what the change actually is? It would make it easier to navigate in the diff.
- After switching to this branch and reloading the settings, i get
Is it expected?
- It is not clear what is specific to the selected context and what is global. It might help to group what is context-specific or add an indicator next to each of those fields.
- Maybe it's more explicit or easy to follow for the users if there are 4 "service" blocks: a global one, one for image gen, one for tts, one for stt. Each block would be placed in the related section.
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
|
julien-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need to clarify what is impacted by switching contexts. Either a visual clue of an explanation text in a note card.
We should mention that text generation is necessarily configured with the default context.
| } else { | ||
| $serviceName = $this->openAiSettingsService->getServiceName(); | ||
| if ($serviceType === 'image' && $this->openAiSettingsService->imageOverrideEnabled()) { | ||
| $serviceName = $this->openAiSettingsService->getImageServiceName(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's an override (the override URL is defined) it does not mean the service name is defined. We should probably fall back to the default one. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. It does fallback to LocalAI if a service name isn't defined and I think that is a better default than the service name of the text processing provider.
646c2e0 to
dba53a3
Compare
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
dba53a3 to
826cbbf
Compare
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>






Simple Overview

Adds hidden menus for override in the ui. When you select a different context you can specify settings for that context otherwise the default will be used.
Description