fix(HP_SHARED_KEY_FILE): always resolve HP_SHARED_KEY var upon restart #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always resolve the shared key before anything starts
We currently export
HP_SHARED_KEYonly while generating/haproxy.cfg.On a restart where
/haproxy.cfgalready exists and the user supplied onlyHP_SHARED_KEY_FILE, the Python agent could start withoutHP_SHARED_KEYin its env - leading to plugin 400s errors.Fix: always resolve/export HP_SHARED_KEY from env or file at the top of start.sh, once, for the whole process.