๐ 3๋จ๊ณ - ์ฌ๋ค๋ฆฌ(๊ฒ์ ์คํ) #2432
Merged
+581
โ48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore : ์ฝ๋ ์ค๋ง์ถค
javajigi
approved these changes
Dec 31, 2025
Contributor
javajigi
left a comment
javajigi
left a comment
There was a problem hiding this comment.
3๋จ๊ณ ๊ตฌํ ๐
ํผ๋๋ฐฑ ๋ช ๊ฐ ๋จ๊ฒผ๋๋ฐ์.
4๋จ๊ณ ๋ฆฌํฉํฐ๋ง ์งํํ ๋ ํจ๊ป ๋ฐ์ํด ๋ณด๋ฉด ์ข๊ฒ ์ต๋๋ค.
| this(users, new Lines(IntStream.range(0, height.getHeight()) | ||
| .mapToObj(i -> new Line(users.size(), generate)) | ||
| .collect(Collectors.toList()))); | ||
| .collect(Collectors.toList())), null); |
Contributor
There was a problem hiding this comment.
Rewards๊ฐ null์ธ ์ํ์ ์ฌ๋ค๋ฆฌ ํ๊ธฐ๊ฐ ๊ฐ๋ฅํ๊ฐ?
Rewards๊ฐ ํ์๋ผ๋ฉด ์ด ์์ฑ์๋ ์ ๊ฑฐํด๋ ๋์ง ์์๊น?
|
|
||
| import java.util.Objects; | ||
|
|
||
| public class LadderResult { |
| return lines; | ||
| } | ||
|
|
||
| public int move(int position) { |
|
|
||
| import java.util.List; | ||
|
|
||
| public class FixedLadderLineGenerateStrategy implements GenerateLadderLineStrategy { |
Contributor
There was a problem hiding this comment.
FixedLadderLineGenerateStrategy์ ๊ตณ์ด ์ถ๊ฐํ๊ธฐ๋ณด๋ค ๋๋ค๋ก ํ ์คํธ ์ฝ๋๋ฅผ ๊ตฌํํ๋๋ก ํ๋ฉด ์ด๋จ๊น?
Comment on lines
+20
to
+25
| L1 = new Lines( | ||
| new Line(4, new FixedLadderLineGenerateStrategy(true, false, true)), | ||
| new Line(4, new FixedLadderLineGenerateStrategy(false, true, false)), | ||
| new Line(4, new FixedLadderLineGenerateStrategy(true, false, false)), | ||
| new Line(4, new FixedLadderLineGenerateStrategy(false, false, true)) | ||
| ); |
Contributor
There was a problem hiding this comment.
Suggested change
| L1 = new Lines( | |
| new Line(4, new FixedLadderLineGenerateStrategy(true, false, true)), | |
| new Line(4, new FixedLadderLineGenerateStrategy(false, true, false)), | |
| new Line(4, new FixedLadderLineGenerateStrategy(true, false, false)), | |
| new Line(4, new FixedLadderLineGenerateStrategy(false, false, true)) | |
| ); | |
| Lines L1 = new Lines( | |
| new Line(4, size -> List.of(true, false, true)), | |
| new Line(4, size -> List.of(false, true, false)), | |
| new Line(4, size -> List.of(true, false, false)), | |
| new Line(4, size -> List.of(false, false, true)) | |
| ); |
์์ ๊ฐ์ด ๋๋ค๋ก ๊ตฌํํด๋ ๋์ง ์์๊น?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
์๋ ํ์ธ์ ! ์ฌ๋ค๋ฆฌ ๊ฒ์ 3๋จ๊ณ ๋ฆฌ๋ทฐ ์์ฒญ๋๋ฆฝ๋๋ค ! ๐โโ๏ธ
๊ณผ์ ์งํ ๋ด์ฉ