Prioritize full granularity over partial granularity #1598
+112
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts
|
mergify
bot
added
tests-failing
hmstepanek
force-pushed
the
fix-partial-sampled-priority
branch
from
5675c73 to
a217de8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop-hybrid-core-tracing #1598 +/- ##
==============================================================
Coverage ? 79.90%
==============================================================
Files ? 211
Lines ? 24664
Branches ? 3920
==============================================================
Hits ? 19709
Misses ? 3569
Partials ? 1386 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* priority +=2 when full granularity and sampled=true * priority +=1 when partial granularity and sampled=true * always_on sampler for full granularity sets priority=3 instead of 2
hmstepanek
force-pushed
the
fix-partial-sampled-priority
branch
from
a217de8 to
5623745
Compare
hmstepanek
changed the title
hmstepanek
commented
Dec 10, 2025
| ( | ||
| (True, "always_off", True, "adaptive", None, None, True), # Uses adaptive sampling algo. | ||
| (True, "always_on", True, "adaptive", True, 2, False), # Uses adaptive sampling algo. | ||
| (False, "always_on", False, "adaptive", False, 0, False), # Uses adaptive sampling algo. |
Contributor
Author
There was a problem hiding this comment.
I moved this into the new test case below so we can actually check the value of priority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Prioritize full granularity over partial granularity: