Skip to content

Conversation

@alexfikl
Copy link
Contributor

Adds linting with ruff and fixes all the issues.

xref: neurophysik/CHSPy#8

@alexfikl alexfikl force-pushed the ruff branch 3 times, most recently from 0ba763d to 54ccefb Compare January 15, 2025 12:14
@Wrzlprmft Wrzlprmft merged commit f37b426 into neurophysik:master Jan 20, 2025
8 checks passed
@Wrzlprmft
Copy link
Contributor

Wonderful. Thanks once more.

Wrzlprmft added a commit that referenced this pull request Jan 20, 2025
@Wrzlprmft
Copy link
Contributor

FYI: There was a tiny bug introduced by the process, which I fixed here. This only affected building the documentation, which is probably how it fell under the radar. I don’t know whether this was a human error or introduced by the linter. In the latter case, it’s probably a bug worth reporting.

@alexfikl
Copy link
Contributor Author

alexfikl commented Jan 20, 2025

FYI: There was a tiny bug introduced by the process, which I fixed here. This only affected building the documentation, which is probably how it fell under the radar. I don’t know whether this was a human error or introduced by the linter. In the latter case, it’s probably a bug worth reporting.

Oops, sorry! That was a human error, I'm afraid.. I did a quick line sort (with vim) in the list and didn't notice there was a missing comma :(

Thanks for fixing it! I'll remember to check the docs build too next time.

@alexfikl alexfikl deleted the ruff branch January 20, 2025 16:04
@alexfikl
Copy link
Contributor Author

For what it's worth

   "something",
   "something else"
   " and this",

is not a syntax error or anything like that, since it just performs implicit string concatenation between line 2 and 3. There's a ruff check for that if you want to turn it on: https://docs.astral.sh/ruff/rules/multi-line-implicit-string-concatenation/.

@Wrzlprmft
Copy link
Contributor

I am aware – except for the Ruff check, which I don’t think is necessary (but I also do not oppose).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants