-
Notifications
You must be signed in to change notification settings - Fork 10
Enable linting with ruff #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0ba763d to
54ccefb
Compare
|
Wonderful. Thanks once more. |
|
FYI: There was a tiny bug introduced by the process, which I fixed here. This only affected building the documentation, which is probably how it fell under the radar. I don’t know whether this was a human error or introduced by the linter. In the latter case, it’s probably a bug worth reporting. |
Oops, sorry! That was a human error, I'm afraid.. I did a quick line sort (with vim) in the list and didn't notice there was a missing comma :( Thanks for fixing it! I'll remember to check the docs build too next time. |
|
For what it's worth is not a syntax error or anything like that, since it just performs implicit string concatenation between line 2 and 3. There's a ruff check for that if you want to turn it on: https://docs.astral.sh/ruff/rules/multi-line-implicit-string-concatenation/. |
|
I am aware – except for the Ruff check, which I don’t think is necessary (but I also do not oppose). |
Adds linting with ruff and fixes all the issues.
xref: neurophysik/CHSPy#8