Skip to content
This repository was archived by the owner on May 27, 2025. It is now read-only.

Conversation

@DataWearsAHood
Copy link

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

fgaillot-qosenergy and others added 26 commits June 24, 2024 22:45
)

Signed-off-by: Florian Gaillot <fgaillot@qosenergy.com>
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
change the host with endpoint to make it worked
Signed-off-by: bakito <github@bakito.ch>
Signed-off-by: bakito <github@bakito.ch>
…e of DB default setting (#201)

Signed-off-by: Marius Leahu <Marius.Leahu@swisscom.com>
Signed-off-by: Marius Ziemke <marius@ziemke.net>
Co-authored-by: Marius Ziemke <marius@ziemke.net>
* feat: add custom tls config support

Signed-off-by: Mathieu Frenette <silphid@users.noreply.github.com>

* use provider config name to make tls name unique

Signed-off-by: Mathieu Frenette <silphid@users.noreply.github.com>

* refactor integration tests into modular functions

Signed-off-by: Mathieu Frenette <silphid@users.noreply.github.com>

---------

Signed-off-by: Mathieu Frenette <silphid@users.noreply.github.com>
Co-authored-by: Mathieu Frenette <silphid@users.noreply.github.com>
Signed-off-by: Duologic <jeroen@simplistic.be>
Signed-off-by: Duologic <jeroen@simplistic.be>
…es (#207)

- added a field called revokePublicOnDb in grant resource; if true, it will revoke from public access to DB; This usually a DBA requirement.
- added a field called revokePublicOnSchema in schema resource; if true, it will revoke from public access to a schema; This usually a DBA requirement.

Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
Signed-off-by: Duologic <jeroen@simplistic.be>
Signed-off-by: Lars Haugan <lars.haugan@sparebank1.no>
bump github actions upload-action to latest release due to deprecation
* chore: bump golangci

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>

* chore: bump golangci on github actions workflow

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>

* chore: bump golangci up to v2, bump up all action dependencies

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>

* chore: even more actions pinned

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>

---------

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
Go 1.23.9 is a security update, and we also need to update
Go to get dependabot security updates out (dependabot does not
run 'go mod tidy').

Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.21.0 to 0.35.0.
- [Commits](golang/crypto@v0.21.0...v0.35.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.35.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.25.0 to 0.38.0.
- [Commits](golang/net@v0.25.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps google.golang.org/protobuf from 1.31.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-version: 1.33.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: enable management policies

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>

* fix: linter

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>

* chore: offload lint changes to #216

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>

* chore: revert changes as per peer review

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>

---------

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
As requested on slack

Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
* chore: remove duplicate entry of golangci version

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>

* chore: bump up versions for crossplane 1.20

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>

* chore: restore changes

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>

---------

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
@DataWearsAHood DataWearsAHood requested review from a team, alexstojda and silphid and removed request for a team May 22, 2025 19:40
@snyk-io
Copy link

snyk-io bot commented May 22, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@codecov
Copy link

codecov bot commented May 22, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@silphid
Copy link

silphid commented May 22, 2025

Not sure we want/need to keep in sync with upstream (see my comment in ticket)

@DataWearsAHood
Copy link
Author

Not sure we want/need to keep in sync with upstream (see my comment in ticket)
Sounds good.

For the short-term, I'm specifically interested in these Dockerfile updates - moving from go 1.21 to 1.23 (and update the vulnerable x/crypto): https://github.com/crossplane-contrib/provider-sql/blame/master/go.mod#L3

What's the best way to pull that into our local copy?

@silphid
Copy link

silphid commented May 23, 2025

Not sure we want/need to keep in sync with upstream (see my comment in ticket)
Sounds good.

For the short-term, I'm specifically interested in these Dockerfile updates - moving from go 1.21 to 1.23 (and update the vulnerable x/crypto): https://github.com/crossplane-contrib/provider-sql/blame/master/go.mod#L3

What's the best way to pull that into our local copy?

Maybe try adding the upstream repo as an extra origin to our provider-sql-nesto (not this one) and cherry-picking commits from it into a PR branch that we can then merge into master?

See examples here:
https://chatgpt.com/share/6830817b-56e8-8012-8347-205e99afef36

@alexstojda alexstojda removed their request for review May 23, 2025 17:16
@DataWearsAHood
Copy link
Author

Upstream pulled into https://github.com/nestoca/provider-sql/tree/upstream, as a possible intermediate step (TBC)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.