-
Notifications
You must be signed in to change notification settings - Fork 0
Mpestle readme update #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @mpestle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a diagnostic step to understand and resolve a recent CI pipeline failure. The author has deliberately introduced a change to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be a debugging step to address a CI failure caused by an upstream Docker image change. The change in .gitlab-ci.yml intentionally specifies a non-existent image tag to test the failure. My review includes a recommendation to pin the Docker image to a specific version tag or digest in the final fix to ensure build reproducibility and prevent future breakages.
| @@ -1,4 +1,4 @@ | |||
| image: nikolaik/python-nodejs | |||
| image: nikolaik/python-nodejs:python3.14-nodejs25-slimxxxx | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good practice to pin your Docker images to a specific version tag or even a digest (@sha256:...) instead of relying on a floating tag like latest (which is the default when no tag is specified). This ensures your CI builds are reproducible and won't break unexpectedly due to upstream changes in the image.
I see you're currently testing with a non-existent tag. For the final fix, you should find a stable, existing tag that meets your requirements. For example, if you need Python 3.12 and a recent Node.js version, you might look for a tag like python3.12-nodejs20-slim (this is just an example, you'll need to check the available tags for the nikolaik/python-nodejs repository).
Trying to figure out how to fix the image, changes to which (outside our control) broke things yesterday. I've specified a non-existent image in this ci file this time, so hope that this will fail.