Skip to content

Add aria-label to select elements #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
recrwplay merged 1 commit into from
Dec 10, 2025
Merged

Add aria-label to select elements #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/partials/nav-cheat-sheet.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{{#if (eq page.attributes.theme 'cheat-sheet') }}
<div class="nav-panel-types{{#unless page.navigation}} is-active{{/unless}}" data-panel="explore" data-selector-type="products">
<div class="dropdown">
<select id="cheat-sheet-selector-products" class="cs-selector dropdown-styles" data-label-type="products">
<select aria-label="Product" id="cheat-sheet-selector-products" class="cs-selector dropdown-styles" data-label-type="products">
{{!-- <option value="all" data-label="all" data-class="all" data-label-type="products">All</option> --}}
{{#each page.attributes.cheatsheet-products}}
{{#if this.default}}
Expand All @@ -23,7 +23,7 @@
<div class="nav-panel-types{{#unless page.navigation}} is-active{{/unless}}" data-panel="explore" data-selector-type="categories">
{{!-- categories - eg read, write, structure, general --}}
<div class="dropdown">
<select id="cheat-sheet-selector-categories" class="cs-selector dropdown-styles" data-label-type="categories">
<select aria-label="Cypher category" id="cheat-sheet-selector-categories" class="cs-selector dropdown-styles" data-label-type="categories">
<option value="all" data-label="all" data-class="all" data-label-type="categories">All</option>
{{#each page.attributes.cheatsheet-categories}}
{{#if this.default}}
Expand Down
2 changes: 1 addition & 1 deletion src/partials/nav-explore.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<div class="dropdown">
<span class="dropdown-label">Neo4j Version</span>

<select data-current="{{@root.page.version}}" class="version-selector dropdown-styles">
<select aria-label="Version" data-current="{{@root.page.version}}" class="version-selector dropdown-styles">
{{#each page.versions}}
{{#unless (or this.prerelease (and (eq this.version @root.page.version) (eq @root.page.attributes.theme 'cheat-sheet') ))}}
<option
Expand Down
6 changes: 3 additions & 3 deletions src/partials/nav-selectors.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<div class="dropdown">
<span class="dropdown-label">{{#with (or page.attributes.cheatsheet-product 'Product')}}{{this}}{{/with}} Version</span>

<select id="selector-version" data-current="{{@root.page.version}}" class="version-selector dropdown-styles">
<select aria-label="Version" id="selector-version" data-current="{{@root.page.version}}" class="version-selector dropdown-styles">
{{#each page.versions}}
{{#unless (and this.prerelease @root.page.attributes.nav-selectors-hide-prerelease)}}
<option
Expand All @@ -41,7 +41,7 @@
<div class="selectors">
<div class="nav-panel-types{{#unless page.navigation}} is-active{{/unless}}" data-panel="explore" data-selector-type="products">
<div class="dropdown">
<select id="cheat-sheet-selector-products" class="cs-selector dropdown-styles" data-label-type="products">
<select aria-label="Product" id="cheat-sheet-selector-products" class="cs-selector dropdown-styles" data-label-type="products">
{{!-- <option value="all" data-label="all" data-class="all" data-label-type="products">All</option> --}}
{{#each page.attributes.cheatsheet-products}}
{{#if this.default}}
Expand All @@ -63,7 +63,7 @@
<div class="nav-panel-types{{#unless page.navigation}} is-active{{/unless}}" data-panel="explore" data-selector-type="categories">
{{!-- categories - eg read, write, structure, general --}}
<div class="dropdown">
<select id="cheat-sheet-selector-categories" class="cs-selector dropdown-styles" data-label-type="categories">
<select aria-label="Cypher category" id="cheat-sheet-selector-categories" class="cs-selector dropdown-styles" data-label-type="categories">
<option value="all" data-label="all" data-class="all" data-label-type="categories">All</option>
{{#each page.attributes.cheatsheet-categories}}
{{#if this.default}}
Expand Down