forked from openedx/frontend-app-authoring
-
Notifications
You must be signed in to change notification settings - Fork 0
Crls/delete publish button #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ccantillo
wants to merge
14
commits into
master
Choose a base branch
from
crls/delete-publish-button
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
requested changes
Dec 30, 2025
Collaborator
johanseto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a first iteration. Could you fix the lintern issues to pass the validate.ci tests.
https://github.com/nelc/frontend-app-authoring/actions/runs/20604854970/job/59178340073#step:4:93
0897bfe to
adddb99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds role-based visibility control for the course unit publish button. Previously, all course team members could see and use the publish button. Now, the button is hidden by default for staff members, while instructors continue to see it.
Why this change?
In many Open edX deployments, staff members shouldn't have the ability to publish content - that responsibility should be limited to instructors who have oversight of the course. This change enforces that separation of concerns at the UI level.
How it works:
User roles impacted:
Supporting information
This change introduces a new plugin slot:
org.openedx.frontend.authoring.course_unit_publish_button.v1The role check uses the existing course team API endpoint (
/api/contentstore/v1/course_team/{courseId}), so no backend changes are required.Testing instructions
Manual testing steps:
Create a test course and add two users to the course team:
Log in as User A (staff):
Log in as User B (instructor):
Test the plugin slot (optional for operators):
Other information
Dependencies:
Breaking changes: