Skip to content

Conversation

@djstrong
Copy link
Collaborator

@djstrong djstrong commented Dec 19, 2025

Tests fail because output from ENSNode API is different than from RPC.

================================================================ short test summary info =================================================================
FAILED tests/test_api.py::test_primary_name[0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045-unlikely-normalized-vitalik.eth-vitalik.eth-vitalik.eth-False-vitalik.eth] - AssertionError: assert None == 'unlikely'
FAILED tests/test_api.py::test_primary_name[0x9d32572997DA4948063E3Fc11c2552Eb82F7208E-unlikely-normalized-poet.base.eth-poet.base.eth-poet.base.eth-False-poet.base.eth] - AssertionError: assert None == 'unlikely'
FAILED tests/test_api.py::test_primary_name[0xfA9A134f997b3d48e122d043E12d04E909b11073-None-unnormalized-None-Unnamed fa9a-None-False-888\u200d\u200d.eth] - AssertionError: assert 'no_primary_name' == 'unnormalized'
FAILED tests/test_api.py::test_primary_name[0x76fd9b1B2d8F2cd9Ba06c925506627883F97B97C-None-unnormalized-None-Unnamed 76fd-None-False-\u200d\u200d\u2764\u200d\u200d.eth] - AssertionError: assert 'no_primary_name' == 'unnormalized'
FAILED tests/test_api.py::test_primary_name[0xf537a27F31d7A014c5b8008a0069c61f827fA7A1-None-unnormalized-None-Unnamed f537-None-False-\u0660\u0660\u06f1.eth] - AssertionError: assert 'no_primary_name' == 'unnormalized'
FAILED tests/test_api.py::test_primary_name[0x0ebDfD75d33c05025074fd7845848D44966AB367-None-unnormalized-None-Unnamed 0ebd-None-False-\u06f8\u06f8\u06f7\u06f5\u06f4\u06f2.eth] - AssertionError: assert 'no_primary_name' == 'unnormalized'
FAILED tests/test_api.py::test_primary_name[0xaf738F6C83d7D2C46723b727Ce794F9c79Cc47E6-None-unnormalized-None-Unnamed af73-None-False-\u0b68\u0b68\u0b68\u0b68\u0b68.eth] - AssertionError: assert 'no_primary_name' == 'unnormalized'
FAILED tests/test_api.py::test_primary_name[0xb281405429C3bc91e52707a21754cDaCeCbB035E-None-unnormalized-None-Unnamed b281-None-False-\u2523\u2587\u2587\u2587\u2550\u2500.eth] - AssertionError: assert 'no_primary_name' == 'unnormalized'
FAILED tests/test_api.py::test_primary_name[0x0d756ee0e8C250f88f5e0eDd7C723dc3A0BF75cF-None-unnormalized-None-Unnamed 0d75-None-False-\u0441\u0431\u0435\u0440.eth] - AssertionError: assert 'no_primary_name' == 'unnormalized'
FAILED tests/test_api.py::test_primary_name[0x7Da3CdE891a76416ec9D1c3354B8EfE550Bd4e20-None-unnormalized-None-Unnamed 7da3-vitalik.eth-True-vit\u0227lik.eth] - AssertionError: assert 'no_primary_name' == 'unnormalized'
FAILED tests/test_api.py::test_primary_name[0xC9f598BC5BB554B6A15A96D19954B041C9FDbF14-None-unnormalized-None-Unnamed c9f5-vitalik.eth-True-v\u0131talik.eth] - AssertionError: assert 'no_primary_name' == 'unnormalized'
FAILED tests/test_api.py::test_primary_name[0x7c7160A23b32402ad24ED5a617b8a83f434642d4-unlikely-normalized-vinc\u03bent.eth-vinc\u039ent.eth-vinc\u03bent.eth-False-vinc\u03bent.eth] - AssertionError: assert 'pudgyvincent.eth' == 'vincξnt.eth'
FAILED tests/test_api.py::test_primary_name[0x744Ec0A91D420c257aE3eE471B79B1A6a0312E36-None-unnormalized-None-Unnamed 744e-None-False-hello<world>!.eth] - AssertionError: assert 'no_primary_name' == 'unnormalized'
FAILED tests/test_api.py::test_primary_name_get - AssertionError: assert None == 'unlikely'
FAILED tests/test_api.py::test_primary_name_get_no_report - AssertionError: assert None == 'unlikely'
FAILED tests/test_api.py::test_primary_name_get_report - AssertionError: assert None == 'unlikely'
FAILED tests/test_api.py::test_primary_name_get_uppercase - AssertionError: assert None == 'unlikely'
FAILED tests/test_api.py::test_primary_name_get_offchain - AssertionError: assert None == 'unlikely'
FAILED tests/test_api.py::test_primary_name_get_unnormalized - AssertionError: assert 'no_primary_name' == 'unnormalized'
FAILED tests/test_api.py::test_primary_name_get_uninspected - AssertionError: assert 'no_primary_name' == 'uninspected'
FAILED tests/test_nameguard.py::test_dynamic_check_order - AttributeError: 'NoneType' object has no attribute 'checks'
FAILED tests/test_nameguard.py::test_secure_primary_name_error - AssertionError: assert <SecurePrimar... 'normalized'> == 'no_primary_name'
================================================= 22 failed, 190 passed, 2 xfailed in 115.80s (0:01:55) ==================================================

E.g. for address 0xFD9eE68000Dc92aa6c67F8f6EB5d9d1a24086fAd we got exampleprimary.cb.id from ENSNode but null from Alchemy.
https://api.alpha.ensnode.io/api/resolve/primary-name/0xFD9eE68000Dc92aa6c67F8f6EB5d9d1a24086fAd/1 ;
https://api.alpha.ensnode.io/api/resolve/primary-name/0xc9f598bc5bb554b6a15a96d19954b041c9fdbf14/1 gives null but Alchemy returns vıtalik.eth (unnormalized)

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2025

⚠️ No Changeset found

Latest commit: 5550563

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
examples.nameguard.io Ready Ready Preview, Comment Dec 19, 2025 8:34am
nameai.io Error Error Dec 19, 2025 8:34am
namegraph.dev Ready Ready Preview, Comment Dec 19, 2025 8:34am
nameguard.io Ready Ready Preview, Comment Dec 19, 2025 8:34am
namehashlabs.org Ready Ready Preview, Comment Dec 19, 2025 8:34am
namekit.io Ready Ready Preview, Comment Dec 19, 2025 8:34am
storybook.namekit.io Ready Ready Preview, Comment Dec 19, 2025 8:34am

@djstrong
Copy link
Collaborator Author

The decision is that ENSNode API behaviour is the correct one (if the primary name is unnormalized then we say there is no primary name) so we need to fix tests. Probably unnormalized state in the endpoint is no longer valid.
"Suggest to change that test (0xFD9eE68000Dc92aa6c67F8f6EB5d9d1a24086fAd) case to the address for jesse.base.eth
(0x2211d1D0020DAEA8039E46Cf1367962070d77DA9)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants