Skip to content

Conversation

@lightwalker-eth
Copy link
Member

CleanShot 2024-09-19 at 00 35 03

This PR removes the build warning above.

I'm curious why we need this line at all though? Should we just entirely remove it?

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2024

⚠️ No Changeset found

Latest commit: ab6da56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nameguard.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 9:43pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples.nameguard.io ⬜️ Skipped (Inspect) Sep 18, 2024 9:43pm
namehashlabs.org ⬜️ Skipped (Inspect) Sep 18, 2024 9:43pm
storybook.namekit.io ⬜️ Skipped (Inspect) Sep 18, 2024 9:43pm

@notrab
Copy link
Member

notrab commented Sep 19, 2024

@lightwalker-eth I think this is still required, but I'd be curious to know what happens if you remove it.

I believe I added this originally before we were building the unique namespaced styles for Namekit. I don't think we do the same thing with nameguard-react yet, so this is why I think it's needed.

Essentially, nameguard-react doesn't export its own styles. So this line in the apps using it, allow the component styles to be detected and built.

We should try to migrate nameguard-react to use a prefix ng- so it can export its own styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants