Feat/tokenscope #970
Merged
Feat/tokenscope #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # apps/ensindexer/package.json # apps/ensindexer/src/plugins/index.ts # packages/datasources/src/mainnet.ts # packages/datasources/src/sepolia.ts # packages/ensnode-schema/src/ponder.schema.ts # packages/ensnode-sdk/src/utils/types.ts # pnpm-lock.yaml
# Conflicts: # packages/datasources/src/mainnet.ts # pnpm-lock.yaml
…ll index Seaport-Sales across all other name-plugins we support (ENS, 3dns etc)
# Conflicts: # packages/ensnode-sdk/src/ens/constants.ts # packages/ensnode-sdk/src/ens/index.ts # packages/ensnode-sdk/src/ens/types.ts # packages/ensnode-sdk/src/index.ts # pnpm-lock.yaml
# Conflicts: # apps/ensindexer/.env.local.example # packages/datasources/src/index.ts # packages/datasources/src/mainnet.ts # packages/datasources/src/sepolia.ts # pnpm-lock.yaml
lightwalker-eth
added
enhancement
🦋 Changeset detectedLatest commit: 522619f The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shrugs
approved these changes
Aug 26, 2025
lightwalker-eth
commented
Aug 26, 2025
Member
Author
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
Super updates and fixed 👍 Just 1 point of feedback that I'll add a reference to in #972 for the future
| } | ||
|
|
||
| return null; | ||
| export const getCurrencyIdForContract = (contract: AccountId): CurrencyId | null => { |
Member
Author
There was a problem hiding this comment.
For strict correctness it seems we should:
- Keep a namespace param on
getCurrencyIdForContract. - Update the data model for
KNOWN_CURRENCY_CONTRACTSso that each record includes its associated namespace. - Update
getSupportedCurrencyContractsForChainso that it also takes a namespace param.- Update logic in this function so that it filters by namespace in addition to the existing chain filtering logic.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #872 and closes #832