Skip to content

Conversation

@tk-o
Copy link
Contributor

@tk-o tk-o commented Jun 24, 2025

This reverts changes from PR #804

@tk-o tk-o requested a review from a team as a code owner June 24, 2025 11:08
@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2025

⚠️ No Changeset found

Latest commit: ec8f7c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
admin.ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2025 11:17am
ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2025 11:17am
ensrainbow.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2025 11:17am

@tk-o
Copy link
Contributor Author

tk-o commented Jun 24, 2025

I spoke with @shrugs and we agreed to keep using POJO values when selecting ENSNamespace or DatasourceName.

@shrugs
Copy link
Collaborator

shrugs commented Jun 24, 2025

If you want to use the enum-like values in the code, though, you can still do ENSNamespaceIds.EnsTestEnv

@tk-o tk-o merged commit 7854d14 into main Jun 24, 2025
7 checks passed
@tk-o tk-o deleted the refactor/revert-ensnamespaceid-enum branch June 24, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants