-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add CSV conversion command to ensrainbow CLI #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
djstrong
wants to merge
23
commits into
main
Choose a base branch
from
csv-conversion-tool
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
2006959
feat: add CSV conversion command to ensrainbow CLI
djstrong b491441
refactor
djstrong 4c18e0b
Create brave-kiwis-notice.md
djstrong 5aefe9d
fix tests
djstrong f2c8f20
use fast-csv package
djstrong e20932d
add documentation for csv convert
djstrong b9c31b0
feat: add filtering capabilities to CSV conversion
djstrong e2b9255
feat: enhance CSV conversion with Bloom filter and deduplication options
djstrong 2c94d41
refactor: simplify command options in package.json
djstrong 721a50d
refactor: improve memory management and logging in CSV conversion
djstrong 56bc356
refactor: streamline CSV conversion CLI options and improve logging
djstrong 11992d7
fix: improve error handling and logging in CSV conversion tests
djstrong 3dea60e
refactor: update CSV conversion logic and improve deduplication handling
djstrong b6c668a
Merge branch 'main' into csv-conversion-tool
djstrong b02b7f1
refactor: remove unused dependencies and enhance CSV conversion tests
djstrong 35a05cb
Apply suggestions from code review
djstrong 2cc8cad
refactor: rename convert command to convert-sql and update CLI docume…
djstrong bbc2786
refactor: update CLI documentation for output file and label set desc…
djstrong af4b041
docs: enhance SQL conversion section with repository link for legacy …
djstrong 0ebee69
refactor: update CLI to make output-file optional and enhance documen…
djstrong 9cdbb39
fix: enforce existing database path requirement in CLI and improve er…
djstrong a7fd4f3
refactor: update createRainbowRecord function to use RainbowRecord ty…
djstrong aac6789
refactor: remove label set version requirement from CLI and enhance o…
djstrong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "ensrainbow": patch | ||
| --- | ||
|
|
||
| feat: add CSV conversion command to ensrainbow CLI to convert rainbow tables from CSV format to ensrainbow format |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
@fast-csv/parsedependency is added to the dependencies list, but it's placed afteryargswith a trailing comma. The placement is correct, but ensure the dependency ordering follows the project's conventions (typically alphabetical order would place it before the existing dependencies).