-
Notifications
You must be signed in to change notification settings - Fork 4
refactor: split up poll_transmit into per_path and per_space parts #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
83c7f3c to
e68e283
Compare
9e62887 to
20d8450
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
- Coverage 76.01% 75.99% -0.03%
==========================================
Files 81 81
Lines 22569 22626 +57
==========================================
+ Hits 17156 17194 +38
- Misses 5413 5432 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c074a71 to
6d41a6a
Compare
7654439 to
44225e3
Compare
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/255/docs/iroh_quinn/ Last updated: 2026-01-07T11:18:32Z |
|
We do need this is some form, this is a good option. At some point I thought whether we should to per path, per space, or per space and per path (nesting ordering) and ofc with the current code the correct answer is path and then space. The thing is that this is consequence of a "bad" code design (the best we could come up with at the beginning) because paths are spaces. So I'm wondering if we should instead take the route of modeling spaces correctly as: I'm worried taking this route would make it harder to move in that direction. I also don't want to stop this in favor a non existent better way we don't really (yet) know how hard it is to achieve. Or perhaps this is actually a good intermediate step to get there? Keen to hear y'alls thoughts |
I would argue, even if we want to move to making paths, spaces, this approach already helps and will make life easier for everyone in the meantime |
44225e3 to
7f91667
Compare
Starts to split up
poll_transmitinto per_path and per_space parts.