Skip to content

Conversation

@dignifiedquire
Copy link
Collaborator

Starts to split up poll_transmit into per_path and per_space parts.

@dignifiedquire dignifiedquire force-pushed the refactor-poll-transmit-path branch from 83c7f3c to e68e283 Compare December 13, 2025 21:27
@n0bot n0bot bot added this to iroh Dec 13, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Dec 13, 2025
@dignifiedquire dignifiedquire force-pushed the refactor-poll-transmit-path branch from 9e62887 to 20d8450 Compare December 13, 2025 22:11
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2025

Codecov Report

❌ Patch coverage is 85.44061% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.99%. Comparing base (1240596) to head (7f91667).

Files with missing lines Patch % Lines
quinn-proto/src/connection/mod.rs 85.21% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   76.01%   75.99%   -0.03%     
==========================================
  Files          81       81              
  Lines       22569    22626      +57     
==========================================
+ Hits        17156    17194      +38     
- Misses       5413     5432      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dignifiedquire dignifiedquire changed the title [WIP] Experiment: bring some logical structure to poll_transmit [WIP] Split up poll_transmit into per_path and per_space parts Dec 13, 2025
@dignifiedquire dignifiedquire force-pushed the refactor-poll-transmit-path branch from c074a71 to 6d41a6a Compare December 13, 2025 22:42
@dignifiedquire dignifiedquire marked this pull request as ready for review December 15, 2025 09:04
@dignifiedquire dignifiedquire changed the base branch from main-iroh to main December 20, 2025 15:39
@dignifiedquire dignifiedquire force-pushed the refactor-poll-transmit-path branch from 7654439 to 44225e3 Compare December 20, 2025 15:39
@github-actions
Copy link

github-actions bot commented Dec 20, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/255/docs/iroh_quinn/

Last updated: 2026-01-07T11:18:32Z

@dignifiedquire dignifiedquire changed the title [WIP] Split up poll_transmit into per_path and per_space parts refactor: split up poll_transmit into per_path and per_space parts Dec 20, 2025
@divagant-martian
Copy link
Collaborator

We do need this is some form, this is a good option. At some point I thought whether we should to per path, per space, or per space and per path (nesting ordering) and ofc with the current code the correct answer is path and then space. The thing is that this is consequence of a "bad" code design (the best we could come up with at the beginning) because paths are spaces.

So I'm wondering if we should instead take the route of modeling spaces correctly as:
Initial, Handshake, Path(PathId)
which to my initial questioning, is a single loop.

I'm worried taking this route would make it harder to move in that direction. I also don't want to stop this in favor a non existent better way we don't really (yet) know how hard it is to achieve.

Or perhaps this is actually a good intermediate step to get there?

Keen to hear y'alls thoughts

@dignifiedquire
Copy link
Collaborator Author

Or perhaps this is actually a good intermediate step to get there?

I would argue, even if we want to move to making paths, spaces, this approach already helps and will make life easier for everyone in the meantime

@dignifiedquire dignifiedquire force-pushed the refactor-poll-transmit-path branch from 44225e3 to 7f91667 Compare January 7, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

4 participants