Skip to content

Conversation

@rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Dec 12, 2025

Description

Defers the creation of the Bytes a tiny bit more, so we can decide in the SendBufferData to either copy or create a Bytes.

For anything less than MAX_COMBINE, we will not create a Bytes at all.

Breaking Changes

None

Notes & open questions

That way for small writes we don't have to do it!
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.80%. Comparing base (695025c) to head (a81ead9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   76.78%   76.80%   +0.02%     
==========================================
  Files          83       83              
  Lines       23473    23497      +24     
==========================================
+ Hits        18023    18047      +24     
  Misses       5450     5450              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@n0bot n0bot bot added this to iroh Dec 12, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Dec 12, 2025
@rklaehn rklaehn changed the base branch from main-iroh to main December 16, 2025 12:34
@rklaehn rklaehn changed the base branch from main to fast-send-buffer-2 December 16, 2025 12:35
@flub flub added the performance Things that might improve performance both for iroh and as a normal QUIC library. label Dec 22, 2025
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/252/docs/iroh_quinn/

Last updated: 2025-12-23T14:05:47Z

@rklaehn rklaehn marked this pull request as ready for review December 23, 2025 13:11
@rklaehn rklaehn requested a review from flub December 23, 2025 13:36
Base automatically changed from fast-send-buffer-2 to main December 23, 2025 13:49
@flub flub added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit 4cbbb68 Jan 8, 2026
28 checks passed
@flub flub deleted the bytes-or-slice branch January 8, 2026 20:22
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Things that might improve performance both for iroh and as a normal QUIC library.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants