feat: Implement JoinSet::poll_join_next* and JoinError::try_into_panic
#23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/n0-future/pr/23/docs/n0_watcher/ Last updated: 2026-01-05T15:13:19Z |
3 tasks
dignifiedquire
approved these changes
Jan 7, 2026
github-merge-queue bot
pushed a commit
to n0-computer/iroh
that referenced
this pull request
Jan 8, 2026
…rded_channel.rs` (#3681) ## Description Depends on n0-computer/n0-future#23 for `JoinSet::poll_join_next` and `JoinError::try_into_panic`. - Removes `guarded_channel.rs` - Instead, uses normal mpsc channels, and once it closes them, collects all messages that were missed before the channel was closed, sends them back to the `RemoteMap`, which will immediately spawn a new `RemoteStateActor` in case it missed some messages during shutdown. - Spawns the `RemoteStateActor` in a `JoinSet` that's held in a `Mutex` inside the `RemoteMap` (effectively owned by the magic socket). ## Notes & open questions I think it's good to look at this right now, but some considerations/TODOs: - I don't like the mutex around the JoinSet in `RemoteMap`. Maybe only the `magicsock::Actor` should own the `JoinSet`, and the `RemoteMap` shouldn't actually store it itself. - I'm not sure if draining all "initial messages" in `RemoteStateActor::run` is the right way to do this. ## Change checklist <!-- Remove any that are not relevant. --> - [x] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. --------- Co-authored-by: Franz Heinzmann <frando@unbiskant.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements two new functions for
JoinSets in Wasm, mirroring the same functions on the tokio side, as well as one function onJoinError.Change checklist