feat(iroh): ping paths and trigger holepunching on networkchange #3796
Conversation
dignifiedquire
changed the title
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3796/docs/iroh/ Last updated: 2025-12-19T14:31:20Z |
| }; | ||
| tx.send(info).ok(); | ||
| } | ||
| RemoteStateMessage::NetworkChange { is_major } => { |
There was a problem hiding this comment.
Can we not do this with the local addr watcher? I don't like having two mechanisms for this, and a watcher seemed nice.
There was a problem hiding this comment.
addr change update happens a lot later, this is why I added this mechanism, and it also happens for potentially other reasons. The addr change will happen eventually when net report finishes, but we don't need to wait for that, to already know we want to recheck our connections in here
There was a problem hiding this comment.
I see. could we more often update our local addrs? i don't think if the interfaces change that we need to wait until we've also run netcheck until we get updates. I'd like to receive them all as quickly as possible, but still only via one API.
There was a problem hiding this comment.
one day, but that would require the much bigger refactor of netreport to be more stream based, which will not happen any time soon
| } | ||
|
|
||
| if is_major { | ||
| self.trigger_holepunching(); |
There was a problem hiding this comment.
so this code-path trigges holepunching less often than the watcher for the local addrs? but otherwise does the same? it seems more like the is_major detection should be added to trigger_holepunching. And that should also send pings if that is helpful. but i don't think this is helpful yet, i think we need to be able to see the number of in-flight tail-loss probes in select path to benefit from this.
Depends on n0-computer/quinn#290