Skip to content

Conversation

@dignifiedquire
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3734/docs/iroh/

Last updated: 2025-12-06T09:42:13Z

@n0bot n0bot bot added this to iroh Dec 4, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Dec 4, 2025
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit


let relays = RelayMap::try_from_iter([
"https://use1-1.relay.n0.iroh.iroh.link/",
"https://euc1-1.relay.n0.iroh.iroh.link/",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still inconsistent with our usage of . and / for the relay urls everywhere.

We should be sticking to .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should stick to . in all examples.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And of course, defaults.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not an example but a test, I a actually want to make sure that it also works without . tbh

Copy link
Collaborator

@Arqu Arqu Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, wasn't super clear from that. I thought you wanted to do the same thing in 2 ways ie empty builder and pass it in from an iter.

/// # use iroh_relay::RelayMap;
/// let map =
/// RelayMap::try_from_iter(["https://relay_0.cool.com", "https://relay_1.cool.com"]).unwrap();
/// ```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc comment should probably point out that a default RelayConfig is used and that this means we'll assume the relay URL has QAD running on port 7842 or whatever relevant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@flub flub added this to the iroh: v1.0.0-rc.0 milestone Dec 22, 2025
@flub
Copy link
Contributor

flub commented Dec 22, 2025

@dignifiedquire please update and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

4 participants