Filter councils/scores on Question pages by nation/region/imd/etc #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
my concern with the comparing the filtered list from this year with last is that if you then look at the same filter for the previous year you are going to get different numbers so I guess we possibly want to include something to say that it is only comparing for the councils matched this year, rather than all councils that match in the previous year? |
Member
Author
|
@struan yep, I could add some wording to that effect 👍 |
struan
approved these changes
Dec 16, 2025
Member
struan
left a comment
struan
left a comment
There was a problem hiding this comment.
I've pushed a tidyup to the last commit but otherwise this looks good, modulo the text discussed elsewhere.
zarino
force-pushed
the
769-question-page-filters
branch
3 times, most recently
from
a095825 to
1e9431d
Compare
Switching to the Homepage-style filter buttons will make it easier for us to incorporate Homepage-style filtering by nation/country/etc to the Question pages (#769). Now that the “homepage” filter is being reused on three page types (home, nation, question) this was a good opportunity to generalise some of the code, including: - rename `#home-page-main-filter` to `#main-filter` - rename `ajaxLoadCouncilTypeScorecard` to `ajaxLoadPageFragments` - separate `.loading-shimmer` from `ajaxLoadPageFragments` so that specific child elements can _appear_ to be reloaded, while the JavaScript simply reloads their common parent. I also took the opportunity to tidy up the typography and vertical rhythm of the Question page sections/headings.
Since the table of councils/scores on the Question page can now be filtered by attributes like nation/region/imd/etc, it makes intuitive sense that the statistics _above_ the table should _also_ respect those filters. The rising/falling cards already work with the filters, which is nice. But the breakdown of total councils with each number of points does not. A challenge here is that the points breakdowns include a comparison with the previous year’s data. But filters are year-specific. What does it mean to compare “Labour-controlled English Single Tiers” from 2025 and 2023? I had a bit of a debate with Claude, and it suggested that we make this change – comparing the stats of _the same specific councils_ across the years, rather than trying to apply the same _filters_ across the years. This way, you’ll see how many of the matching councils got each number of points in 2025, and how many points they all got in 2023 too. Seems fairly intuitive to me? But I’d appreciate a second opinion! I am also a little bit “yuck” over how it’s re-implementing something new, instead of re-using `get_scores_breakdown`, but maybe that’s just un-avoidable.
zarino
force-pushed
the
769-question-page-filters
branch
from
1e9431d to
f9b4c58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly works, but I wasn’t sure what to do about the "Points distribution" statistics, since they’re compared across years, and the filter data is year-specific. I’ve had a stab at a potential solution, but TBH I barely understand what the code is doing at that point, so I’m not confident about it. @struan do you have any thoughts?
Fixes #769.