Skip to content

Conversation

@sckp
Copy link

@sckp sckp commented Dec 2, 2025

EE-2366 Add Member Events page

The response data was checked against Postman.

Screenshots from Emma API

image image

Slack Post

Team:  Enhanced Contact Data
Manager: Joe Biggert
Engineer: Sarah Pagnani
Summary: Add Member Events page
Affected: All

@sckp sckp marked this pull request as draft December 2, 2025 23:34
@sckp sckp marked this pull request as ready for review December 2, 2025 23:34
Copy link
Contributor

@Streeter8 Streeter8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things we can touch up, but this is looking good otherwise!

Comment on lines 392 to 411
[
{
"account_id": 100,
"event_timestamp": "@D:2025-12-02T11:23:47",
"event_type_id": 300,
"event_monetary_value": 8.0,
"inserted_at": "@D:2025-12-02T11:23:47"
"mailing_id": null,
"member_id": 555,
},
{
"account_id": 100,
"event_timestamp": "@D:2025-12-02T11:23:47",
"event_type_id": 300,
"event_monetary_value": 2.0,
"inserted_at": "@D:2025-12-02T11:23:47"
"mailing_id": null,
"member_id": 444,
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An adjustment to the sample request body to show different variations of the accepted request format

Suggested change
[
{
"account_id": 100,
"event_timestamp": "@D:2025-12-02T11:23:47",
"event_type_id": 300,
"event_monetary_value": 8.0,
"inserted_at": "@D:2025-12-02T11:23:47"
"mailing_id": null,
"member_id": 555,
},
{
"account_id": 100,
"event_timestamp": "@D:2025-12-02T11:23:47",
"event_type_id": 300,
"event_monetary_value": 2.0,
"inserted_at": "@D:2025-12-02T11:23:47"
"mailing_id": null,
"member_id": 444,
}
]
[
{
"event_timestamp": "@D:2025-12-02T11:23:47",
"event_type_id": 300,
"event_monetary_value": null,
"mailing_id": null,
"member_id": 555,
},
{
"event_timestamp": "@D:2025-12-02T11:23:47",
"event_type": "Purchased Tickets",
"event_monetary_value": 2.0,
"mailing_id": 201,
"email": "emma@myemma.com",
}
]

Comment on lines +149 to +153
"account_id": 100,
"created_at": "@D:2025-11-24T10:23:10",
"display_name": "Visited Website",
"event_type": "visited_website",
"event_type_id": 300
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • account_id is interpreted from the url
  • created_at is set on DB write
  • event_type_id is generated by the db

Since these values are not taken from the request body, we should remove them from the sample request body

Suggested change
"account_id": 100,
"created_at": "@D:2025-11-24T10:23:10",
"display_name": "Visited Website",
"event_type": "visited_website",
"event_type_id": 300
"display_name": "Visited Website",
"event_type": "visited_website",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Streeter8 This is the example response body, not request body.

Theese are the params described for this endpoint.

<td class="field-body">
  <ul class="first simple">
      <li><strong>event_type</strong> (<em>string</em>) &#8211; Required. The type of the event.</li>
      <li><strong>display_name</strong> (<em>string</em>) &#8211; Required. A name for displaying the event in the UI.</li>
  </ul>
</td>

And then this is the sample response:

{
    "account_id": 100,
    "created_at": "@D:2025-11-24T10:23:10",
    "display_name": "Visited Website",
    "event_type": "visited_website",
    "event_type_id": 300
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants