Skip to content

Conversation

@ridwannurhayat
Copy link

Change logger to slf4j to make it able to run in native mode on spring-boot 4

@kazuki43zoo kazuki43zoo added this to the 4.0.0 milestone Nov 30, 2025
@kazuki43zoo kazuki43zoo self-assigned this Nov 30, 2025
@kazuki43zoo kazuki43zoo added enhancement Improve a feature or add a new feature no backward compatibility Includes change no backward compatibility for previous version labels Nov 30, 2025
@kazuki43zoo
Copy link
Member

@ridwannurhayat
Why are you only modifying the ClassPathMapperScanner.java?

@kazuki43zoo kazuki43zoo removed this from the 4.0.0 milestone Nov 30, 2025
@hazendaz
Copy link
Member

@ridwannurhayat Spring is using commons-logging, while I personally prefer slf4j, would it make more sense to align it with its actual underlying usage? Maybe it doesn't quite matter. For some time I've been suggesting we dump mybatis logging entirely and move to slf4j, most modules already are using slf4j. But I did want to note that spring itself is not.

@hazendaz
Copy link
Member

This will have to come at a later time. The logging is internal and should be removed or at least deprecated. All the others would need cleaned up. Consideration should be taken into account if we align to spring here rather than spring boot. Also note that mybatis internals is still going to use the logging abstracted away so this may not be worthwhile until we make a firm stance on mybatis after 3.6.0 release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve a feature or add a new feature no backward compatibility Includes change no backward compatibility for previous version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants