Skip to content

add the ability to pause publishing in the redis queue and lengthen t… #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abrandoned wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add the ability to pause publishing in the redis queue and lengthen t… #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e21cc26
add the ability to pause publishing in the redis queue and lengthen t…
abrandoned Oct 11, 2020
e1eda6c
use boolean version
abrandoned Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/active_publisher/async/redis_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def self.new(*args)
end

class Adapter
QUEUE_FLUSH_SIZE = 100
SUPERVISOR_INTERVAL = {
:execution_interval => 1.5, # seconds
:timeout_interval => 1, # seconds
Expand Down Expand Up @@ -41,7 +42,7 @@ def initialize(new_redis_pool)
def publish(route, payload, exchange_name, options = {})
message = ::ActivePublisher::Message.new(route, payload, exchange_name, options)
queue << ::Marshal.dump(message)
flush_queue! if queue.size >= 20 || options[:flush_queue]
flush_queue! if queue.size >= QUEUE_FLUSH_SIZE || options[:flush_queue]

nil
end
Expand Down
9 changes: 9 additions & 0 deletions lib/active_publisher/async/redis_adapter/redis_multi_pop_queue.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ module ActivePublisher
module Async
module RedisAdapter
class RedisMultiPopQueue
RABBITMQ_PAUSED_KEY = "ACTIVE_PUBLISHER_RABBITMQ_PAUSED".freeze

attr_reader :list_key, :redis_pool

def initialize(redis_connection_pool, new_list_key)
Expand Down Expand Up @@ -36,6 +38,12 @@ def empty?
size <= 0
end

def pause_publishing?
redis_pool.with do |redis|
redis.exists?(RABBITMQ_PAUSED_KEY)
end
end

def pop_up_to(num_to_pop, opts = {})
case opts
when TrueClass, FalseClass
Expand Down Expand Up @@ -73,6 +81,7 @@ def pop_up_to(num_to_pop, opts = {})
def shift(number)
number = [number, size].min
return [] if number <= 0
return [] if pause_publishing?

messages = []
multi_response = []
Expand Down