Skip to content

Conversation

@abrandoned
Copy link
Contributor

…te where errors are stored

I think this was discussed today so wanted to get something out there that we can use and hopefully stop losing some of the messages on publish when done synchronously

@film42 @liveh2o @newellista

@film42
Copy link
Contributor

film42 commented Jan 15, 2019

So this can block for up to 5 minutes on a synchronous publish? I’m worried that this might backfire for users who were expecting this to blow up instantly.

What if we instead looked at rotating out the connection when it’s in a disconnected state? We can’t do this for action subscriber without reworking quite a bit, but we should be able to do this in active publisher no problem.

@abrandoned
Copy link
Contributor Author

@film42 I just put up a change that just calls a disconnect! when we are in a network error state ... however we do have automatic recovery turned on, so technically we can just wait a tick (100ms even) for the recover to kick in ... do we want to degrade, just faster?

@liveh2o
Copy link
Contributor

liveh2o commented Jan 15, 2019

I'm good with either option. I'm more curious as to why this started popping up under JRuby 9.1.17.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants