r_overBrightBitsJKA: Overbright settings only for maps recognized as JKA map #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JKA map These are: * maps loaded from pk3 in basejka or fs_assetspathjka directories * maps loaded from pk3 with ojka_ prefix * maps loaded from pk3 with "compatible jka" string in mv.info file
|
wow you really like overcomplicating |
Contributor
|
This pull request breaks support for custom Before this pull request: After this pull request: |
Member
Author
|
Thanks for testing, I'll check it out (if we are even going the merge this pr in the end) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are:
There is a function in place now (MV_GetCurrentMapVersion()) to change engine behaviour depending if map is considered jk2 map or jka - even if the rules how we detect this change.
Some ideas: