Add missing test to JSON conversion #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Update: this appears to be an omission from #35, which is a very old PR that was merged only recently. This explains how it could be left behind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was regenerating the JSON because of #180. To my surprise, this test was added to the JSON as well. It seems to have been missing ever since the corresponding test in the YAML was added in 2012. I have no idea how it escaped every time, for example also in #113 and #119.
I am not waiting for a review, because this is just bringing the JSON up to date with the YAML. However, I am still submitting a pull request for the sake of openness.