refactor: Rename VisionControllerClient to VisionClient #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a second attempt to merge #39 . However I'm not sure if we can actually make such changes. Since they are not backwards compatible. E.g. `from mujinvisioncontrollerclient import visioncontrollerclient` will not work anymore. Maybe we should add alternative class name without renaming the file. Or go all in and rename the module completely.
Contributor
Author
|
@florisatmujin WDYT? Should we rename to VisionClient? @felixvd FYI |
Contributor
|
I like the idea, but I think that the impact could be large, and would need changes in multiple repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt to merge #39 .
However I'm not sure if we can actually make such changes. Since they are not backwards compatible. E.g.
from mujinvisioncontrollerclient import visioncontrollerclientwill not work anymore.Maybe we should add alternative class name without renaming the file. Or go all in and rename the module completely.