forked from AustinCodingAcademy/csharp-workbook
-
Notifications
You must be signed in to change notification settings - Fork 0
added error message if player choses something other than rock paper … #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mtrich
wants to merge
1
commit into
master
Choose a base branch
from
week4-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| using System; | ||
|
|
||
| namespace RockPaperScissors | ||
| { | ||
| class Program | ||
| { | ||
| public static void Main() | ||
| { | ||
| //asks for user input | ||
| Console.WriteLine("Enter your move:"); | ||
| string hand1 = Console.ReadLine().ToLower(); | ||
|
|
||
| //if player enters invalid hand, throws exception and asks for valid input | ||
| while(hand1 != "rock"&&hand1 != "paper"&&hand1 != "scissors"){ | ||
| try{ | ||
|
|
||
| if (hand1 != "rock"&&hand1 != "paper"&&hand1 != "scissors") | ||
| { | ||
| throw new Exception ("Invalid move"); | ||
| } | ||
| } | ||
| catch(Exception) { | ||
|
|
||
| Console.WriteLine("Invalid move entered please try again"); | ||
| hand1 = Console.ReadLine().ToLower(); | ||
| } | ||
| } | ||
| Console.WriteLine(outcome(compareHands(hand1,hand2()))); | ||
| //prevents program from closing | ||
| Console.ReadLine(); | ||
| } | ||
| public static string hand2() | ||
| { | ||
| //random computer input | ||
| Random rnd = new Random(); | ||
| int computerMove = rnd.Next(1,4); | ||
|
|
||
| if (computerMove == 1){ | ||
| Console.WriteLine("Computer chose rock"); | ||
| return "rock"; | ||
| } | ||
| else if (computerMove == 2){ | ||
| Console.WriteLine("Computer chose paper"); | ||
| return "paper"; | ||
| } | ||
| else{ | ||
| Console.WriteLine("Computer chose scissors"); | ||
| return "scissors"; | ||
| } | ||
| } | ||
| public static int compareHands(string hand1, string hand2) | ||
| { | ||
| //Tie condition | ||
| if(hand1 == hand2){ | ||
| return 0; | ||
| } | ||
| //Win Condition | ||
| else if ((hand1 == "rock" && hand2 == "scissors")||(hand1 == "paper" && hand2 == "rock")||(hand1 == "scissors" && hand2 == "paper")){ | ||
| return 1; | ||
| } | ||
| //Loss Condition | ||
| else{ | ||
| return 2; | ||
| } | ||
| } | ||
| public static string outcome(int compareHands) | ||
| { | ||
| //logic to decide outcome | ||
| if(compareHands == 0){ | ||
| return "it's a Tie!"; | ||
| } | ||
| else if(compareHands == 1){ | ||
| return "You Win!"; | ||
| } | ||
| else{ | ||
| return "You Lose!"; | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>netcoreapp2.1</TargetFramework> | ||
| </PropertyGroup> | ||
|
|
||
| </Project> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is will work, but its a little less elegant the way you have it written. You are doing the check 2 times for valid input. Once for they condition to throw an exception, and once for the condition to check if there is a valid hand so you can keep asking for input.
Also, the way you have it, a do/While loop would fit better.