finished checkpoint3 #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousifS
reviewed
Dec 21, 2018
| //instantiates Dao | ||
| static DAO theDao = new DAO(); | ||
| //sets itemList to Dao list | ||
| static List<Item> itemList = theDao.list(); |
There was a problem hiding this comment.
I would not make the list a static variable here. the point of the dao is to get you the ilst when needed. since it might change in the database outside of this program.
yousifS
reviewed
Dec 21, 2018
| } | ||
| static void ListItems(bool statusChecked, bool checkingSpecific) | ||
| { | ||
| foreach(Item listedItem in itemList) |
There was a problem hiding this comment.
instead of using the static 'itemList' here, i would have gotten a "fresh" list from the dao (theDao.list())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.