Remove route long name/trip head-sign FROM direction/stop head-sign

[mmathieum]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the clarity and conciseness of transit information by implementing new mechanisms to remove redundant data from direction and stop headsigns. By introducing configurable options, the system can now intelligently detect and strip identical route long names or trip headsigns, preventing repetitive information from being displayed to users. This change provides greater control over data presentation, leading to a cleaner and more user-friendly experience.

Highlights

• Enhanced Headsign Cleaning: Introduced new configuration options to automatically remove redundant route long names from direction headsigns and both trip headsigns and route long names from stop headsigns.
• Refactored Headsign Cleaning Methods: The cleanDirectionHeadsign method has been updated to accept a GRoute object, providing more context for intelligent headsign cleaning. Similarly, cleanStopHeadSign now leverages new configurations for more precise cleaning.
• Configuration for Redundancy Removal: Added direction_headsign_remove_route_long_name, stop_headsign_remove_trip_headsign, and stop_headsign_remove_route_long_name boolean flags to RouteConfig.kt to control this new behavior.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a feature to remove redundant route long names or trip head-signs from direction and stop head-signs, controlled by new configuration options. The changes are well-implemented across the codebase, including updates to interfaces, configuration classes, and logic in DefaultAgencyTools and MDirectionHeadSignFinder.

I've identified a potential bug in cleanStopHeadSign where a parameter is modified, which could lead to incorrect behavior. I've also suggested a small refactoring in cleanDirectionHeadsign to improve readability and avoid parameter reassignment. Otherwise, the changes look good and the tests have been updated accordingly.