Skip to content

Conversation

@LiNk-NY
Copy link
Collaborator

@LiNk-NY LiNk-NY commented Nov 3, 2025

  • *support local and remote compressed json files
  • re-use checks for url and file
  • update documentation
  • import file_ext() from tools

Copy link
Owner

@mtmorgan mtmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with the PR is that it believes the file name to accurately describe the file content. The pkgdown failure at https://github.com/mtmorgan/rjsoncons/actions/runs/19049336654/job/54405421923?pr=5#step:7:91 occurs because the file says it is '.json.gz' but is actually an ndjson. Apparently this is / was a common practice. So I would rather the PR actually believes the file content rather than the file name.

I guess this has necessary performance consequences for compressed files, especially when remote, because it requires that the file be at least partly decompressed, and hence downloaded, to determine its type. But maybe this better practice anyway -- a local cache of the file while being processed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants