-
Notifications
You must be signed in to change notification settings - Fork 4
Fix issue with partially failing unit-test test_sort_real_schur() #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msmdev
wants to merge
3
commits into
main
Choose a base branch
from
msmdev-unit-test-patch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| docrep>=0.3.1 | ||
| numpy>=1.19.0 | ||
| numpy>=1.19.0,<1.25.0 | ||
| scipy>=1.5.0 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is too restrictive; based on your comment, this is hardware related (works on my M1), would rather skip the test for certain architectures and investigate further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is OS related I would say (not hardware related): with MacOS the test never fails but with Linux...
Or did you try it with Linux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(M1 to M5 are the test matrices used... nothing to do with hardware...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry, just went too quickly through this PR. Seems really like a problem with the combination
numpy>=1.25.0andubuntu,numpy==1.24.4onubuntuseems to work well (based on the 3.8 job).Would consider skipping the combination using this combination.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the
1.25.0release notes, it wasn't immediately obvious which change would be affecting this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually,
1.25.0was OK here: https://github.com/msmdev/pyGPCCA/actions/runs/5306789772/job/14363166673There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing that looked suspicious to me when going through the numpy changelog was the change in
np.r_[]andnp.c_[]. We are using these in the troubled test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is indeed strange that numpy 1.25.0 worked with python 3.9 on ubuntu one time but on the other hand pinning numpy below 1.25.0 solved the problem in all cases. So there should be a connection...
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a closer look, I recognized that the case were 1.25.0 worked was the test using slepc, while 1.25.0 never succeeded without using slepc. But I don't see how this should affect the outcome of this test.