Skip to content

Conversation

@msdio
Copy link
Owner

@msdio msdio commented May 19, 2025

📄 What I've done

Upgrade (almost) all packages

⛱️ Major Changes

1. Upgrade following packages to latest version:

  • typescript
  • react
  • react-router-dom -> react-router
    • changed from createHashRouter to <HashRouter>
  • mui
  • axios
  • firebase
  • framer-motion -> motion
  • gh-pages
  • vite

2. Add task-master-ai mcp server for managing project

All planned tasks for maintenance will be managed by task-master-ai

3. Remove commit hook

Remove annoying pre-commit hook

🤔 References

task master

migration guides

@msdio msdio requested review from Copilot and userJu May 19, 2025 14:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades core dependencies, integrates Taskmaster-AI machinery, updates editor/CI settings, and reorganizes hooks.

  • Bumps TypeScript, React (→19), MUI, Vite, and other libraries; adds "type": "module" and Taskmaster CLI scripts
  • Introduces Taskmaster-AI configuration files (.taskmasterconfig, .roomodes) and rule definitions under .roo/.cursor
  • Adjusts VSCode formatter settings, removes Husky pre-commit hook, and updates GitHub Actions Node version

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Upgraded dependencies, set module type, added Taskmaster scripts
.vscode/settings.json Changed codeActionsOnSave fixAll values
.taskmasterconfig Added Taskmaster-AI configuration
.roomodes Added custom Roo orchestration modes
.husky/pre-commit Removed pre-commit hook script
.github/workflows/deploy.yml Bumped Node version and artifact uploader version
.roo/rules & .cursor/rules Added rule files for Taskmaster-AI modes
Comments suppressed due to low confidence (6)

package.json:28

  • The engines.npm field expects a semver range, not a human message. Consider removing or replacing this with a valid semver (e.g., "npm": ">=6") and rely on the new packageManager field to enforce Yarn usage.
"npm": "please use yarn, not npm",

package.json:66

  • The PR description mentions migrating from react-router-dom to react-router, but the dependency remains react-router-dom. Update the import and dependency to react-router or ensure you're using the expected package.
"react-router-dom": "^6.8.1",

.roomodes:42

  • There's a typo in the roleDefinition ("mdode" should be "mode").
"roleDefinition": "You are Roo, an expert software debugger specializing in systematic problem diagnosis and resolution. When activated by another mdode, your task is to meticulously analyze the provided debugging request..."

.husky/pre-commit:1

  • [nitpick] Removing the pre-commit hook disables lint checks before commits. If this was intentional, consider adding an alternative enforcement mechanism or noting it in the contribution guide.
-#!/usr/bin/env sh

.vscode/settings.json:5

  • editor.codeActionsOnSave expects boolean values; using "explicit" may disable automatic fixes. Change back to true or false as per VSCode schema.
"source.fixAll.stylelint": "explicit",

.github/workflows/deploy.yml:33

  • [nitpick] Node 22 is not an LTS release; consider using an LTS version (e.g., 18 or 20) to ensure CI stability.
node-version: 22

@msdio msdio requested a review from Copilot May 19, 2025 14:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request performs a comprehensive upgrade of many key packages while also incorporating a new task management server and removing a commit hook.

  • Upgrades dependencies (e.g. react, typescript, mui, firebase, etc.) and updates related configuration in package.json
  • Adds new configuration files for task-master-ai and several rule definitions while removing the husky pre-commit hook
  • Updates CI workflow to use Node version 22

Reviewed Changes

Copilot reviewed 44 out of 44 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scripts/prd.txt Added a PRD document with product details and roadmap; review content for typos
package.json Upgraded various dependencies and added new task-master-ai scripts
.taskmasterconfig New configuration file for task-master-ai
.roomodes Added custom modes configuration with detailed role definitions; check for minor typos
.roo/**/* Multiple new rule files added across various modules
.husky/pre-commit Removed pre-commit hook
.github/workflows/deploy.yml Updated Node version from 18 to 22
.cursor/rules/**/* Added new Cursor rules and configuration documentation

scripts/prd.txt Outdated
<context>
# Overview
This project is an website which users can easily make their tech stacks as one image.
With this service, developers don't have to search for svgs, and edit them as one image, capture, and place in their tech stack. They just pick thier tech stacks with search, and submit, and copy & paste result.
Copy link

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo detected in the word 'thier'; please change it to 'their'.

Suggested change
With this service, developers don't have to search for svgs, and edit them as one image, capture, and place in their tech stack. They just pick thier tech stacks with search, and submit, and copy & paste result.
With this service, developers don't have to search for svgs, and edit them as one image, capture, and place in their tech stack. They just pick their tech stacks with search, and submit, and copy & paste result.

Copilot uses AI. Check for mistakes.
.roomodes Outdated
{
"slug": "debug",
"name": "Debug",
"roleDefinition": "You are Roo, an expert software debugger specializing in systematic problem diagnosis and resolution. When activated by another mdode, your task is to meticulously analyze the provided debugging request (potentially referencing Taskmaster tasks, logs, or metrics), use diagnostic tools as instructed to investigate the issue, identify the root cause, and report your findings and recommended next steps back via `attempt_completion`. You focus solely on diagnostics within the scope defined by the delegated task.",
Copy link

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'mdode' appears to be a typo. It should likely be 'mode'.

Suggested change
"roleDefinition": "You are Roo, an expert software debugger specializing in systematic problem diagnosis and resolution. When activated by another mdode, your task is to meticulously analyze the provided debugging request (potentially referencing Taskmaster tasks, logs, or metrics), use diagnostic tools as instructed to investigate the issue, identify the root cause, and report your findings and recommended next steps back via `attempt_completion`. You focus solely on diagnostics within the scope defined by the delegated task.",
"roleDefinition": "You are Roo, an expert software debugger specializing in systematic problem diagnosis and resolution. When activated by another mode, your task is to meticulously analyze the provided debugging request (potentially referencing Taskmaster tasks, logs, or metrics), use diagnostic tools as instructed to investigate the issue, identify the root cause, and report your findings and recommended next steps back via `attempt_completion`. You focus solely on diagnostics within the scope defined by the delegated task.",

Copilot uses AI. Check for mistakes.
@msdio msdio merged commit eb415b5 into main May 20, 2025
@msdio msdio deleted the feat/task-master-mcp branch May 20, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants