Optimization/#281 #284
Open
Optimization/#281 #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issues encountered as of now, will install nodemon dependency for seamless working with code changes
the admin controller works fine with the admin route. can be merged after being reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I made this PR based on the Making the project much optimise #281 Open Issue.
I made a admin controller to transfer all the buisness logic to the controller. please review it and merge if its good enough. I initially planned to make controller for all routes but its a huge codebase and I wasnt sure if I did this one right. I recently learned express and this is my first PR. Please do let me know if I made any mistakes and suggestions so that I could make betetr PRs' in the future. Thanks