[WIP] add ViewConfig arg to NitroView
#1055
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hannojg is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
5 tasks
|
Nice, this can replace a part of my patch. |
|
Any update? |
mrousavy
reviewed
Dec 18, 2025
Comment on lines
+59
to
+63
| // console.log("VIEW CONFIG TYPE:", intersections.map((u) => ({ | ||
| // name: u.getSymbol()?.getName() ?? '<<anonymous>>', | ||
| // baseTypes: u.getBaseTypes().map((bt) => bt.getText()), | ||
|
|
||
| // }))) |
Owner
There was a problem hiding this comment.
Suggested change
| // console.log("VIEW CONFIG TYPE:", intersections.map((u) => ({ | |
| // name: u.getSymbol()?.getName() ?? '<<anonymous>>', | |
| // baseTypes: u.getBaseTypes().map((bt) => bt.getText()), | |
| // }))) |
mrousavy
reviewed
Dec 18, 2025
Comment on lines
+72
to
+73
|
|
||
| console.log("🔥🔥🔥 HOT VIEW CONFIG 🔥🔥🔥", viewConfigSpec) |
Owner
There was a problem hiding this comment.
Suggested change
| console.log("🔥🔥🔥 HOT VIEW CONFIG 🔥🔥🔥", viewConfigSpec) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass an option to nitro view to provide view config configuration.
Goal is to configure recycling support to help with issues as described here: