Fix StackOverflowError in ModularAccumulatorBlockEntity.handlerForCap… #1102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please review and complete all items before submitting your pull request:
MIT License Confirmation
Description
Crash Cause
ModularAccumulatorBlockEntity.handlerForCapability() has a recursive call defect.
When getControllerBE() returns this under certain conditions (e.g., level == null or chunk not loaded) while isController() returns false, it causes handlerForCapability() to infinitely recurse, resulting in a StackOverflowError.
Fix Summary
Added controllerBE != this check in handlerForCapability() to prevent the method from recursively calling itself.