feat: Add no location target to Iterable kit #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmustafa-tse
requested review from
BrandonStalnaker,
denischilik and
nickolas-dimitrakas
BrandonStalnaker
requested changes
Sep 30, 2025
Package.swift
Outdated
Comment on lines
20
to
21
| name: mpIterable, | ||
| targets: [mpIterable]), |
Contributor
There was a problem hiding this comment.
Suggested change
| name: mpIterable, | |
| targets: [mpIterable]), | |
| products: [ | |
| .library(name: mpIterable, targets: [mpIterable]), | |
| .library(name: mpIterableNoLocation, targets: [mpIterableNoLocation]) | |
| ], |
You need to declare the new product
Contributor
Author
There was a problem hiding this comment.
done, thanks for the catch
BrandonStalnaker
merged commit 2f4d22d
into
mparticle-integrations:development
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)