Skip to content

fix: Prevent Integration Attribute Override with NSNull values #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrandonStalnaker merged 2 commits into from
Sep 12, 2025
Merged

fix: Prevent Integration Attribute Override with NSNull values #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10212e1
fix: Prevent Integration Attribute Override with NSNull values
BrandonStalnaker Sep 12, 2025
f66c853
remove invalidMarketingCloudId
BrandonStalnaker Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions mParticle-Adobe/MPIAdobe.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@

static NSString *const errorResponseKey = @"error_msg";

static NSString *const invalidMarketingCloudId = @"<null>";

static NSString *const errorDomain = @"mParticle-Adobe";
static NSString *const serverErrorDomain = @"mParticle-Adobe Server Response";

Expand Down Expand Up @@ -172,13 +170,9 @@ - (void)sendRequestWithMarketingCloudId:(NSString *)marketingCloudId advertiserI
return callbackWithCode(MPIAdobeErrorCodeServerError, @"Server returned an error", error);
}

NSString *marketingCloudId = dictionary[marketingCloudIdKey];
if ([marketingCloudId isEqualToString:invalidMarketingCloudId]) {
marketingCloudId = nil;
}

NSString *region = [NSString stringWithFormat:@"%@", dictionary[regionKey]];
NSString *blob = dictionary[blobKey];
NSString *marketingCloudId = [dictionary[marketingCloudIdKey] isKindOfClass:[NSString class]] ? dictionary[marketingCloudIdKey] : nil;
NSString *region = [dictionary[regionKey] isKindOfClass:[NSString class]] ? dictionary[regionKey] : nil;
NSString *blob = [dictionary[blobKey] isKindOfClass:[NSString class]] ? dictionary[blobKey] : nil;

weakSelf.region = region;
weakSelf.blob = blob;
Expand Down