Skip to content

Conversation

@jamesnrokt
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Maps mParticle Rokt close through to Rokt SDK

Testing Plan

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copilot AI review requested due to automatic review settings July 11, 2025 14:25
@jamesnrokt jamesnrokt requested a review from a team as a code owner July 11, 2025 14:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Maps mParticle’s RoktKit integration to the Rokt SDK’s close and init callbacks.

  • Adds an initialization callback to log whether Rokt setup succeeded.
  • Implements close() to forward the close call to the Rokt SDK.
  • Cleans up imports and suppresses unused warnings on the class.
Comments suppressed due to low confidence (2)

src/main/kotlin/com/mparticle/kits/RoktKit.kt:274

  • Add unit or integration tests to verify that close() correctly invokes Rokt.close() and that any related callbacks or resource cleanup behave as expected.
    override fun close() {

src/main/kotlin/com/mparticle/kits/RoktKit.kt:274

  • If the base KitIntegration class has cleanup logic in its own close() method, you may need to call super.close() here to ensure proper teardown of shared resources.
    override fun close() {

@Mansi-mParticle Mansi-mParticle self-requested a review July 14, 2025 21:50
Copy link
Collaborator

@Mansi-mParticle Mansi-mParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesnrokt jamesnrokt merged commit 9345028 into development Jul 15, 2025
12 of 16 checks passed
@jamesnrokt jamesnrokt deleted the feat/SQDSDKS-7446-rokt-close branch July 15, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants