-
Notifications
You must be signed in to change notification settings - Fork 21
Updated pom version #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pom version #181
Conversation
Signed-off-by: pvsaidurga <saidurgacsea@gmail.com>
WalkthroughThree Maven plugin modules are updated with synchronized version bumps: project version to 1.4.0-SNAPSHOT, esignet.version to 1.8.0-SNAPSHOT, and esignet-signup.version to 1.4.0-SNAPSHOT. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
mosip-identity-plugin/pom.xml (1)
6-8: Restore standard POM element ordering.The
<version>element should follow<artifactId>, not precede it. The conventional POM element order isgroupId,artifactId,version. While Maven will parse this correctly, restoring standard ordering improves consistency.Apply this diff to restore standard POM element ordering:
- <groupId>io.mosip.esignet</groupId> - <version>1.4.0-SNAPSHOT</version> - <artifactId>mosip-identity-plugin</artifactId> + <groupId>io.mosip.esignet</groupId> + <artifactId>mosip-identity-plugin</artifactId> + <version>1.4.0-SNAPSHOT</version>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
mock-plugin/pom.xml(2 hunks)mosip-identity-plugin/pom.xml(2 hunks)sunbird-rc-plugin/pom.xml(2 hunks)
🔇 Additional comments (3)
sunbird-rc-plugin/pom.xml (1)
7-7: Version bump is consistent with other modules in the PR.The project version and esignet.version updates align across all three plugin modules. No POM structure or dependency ordering issues identified.
Also applies to: 83-83
mock-plugin/pom.xml (1)
8-8: Version bumps are synchronized and correctly used by dependencies.The esignet-signup.version property is newly added and properly referenced by signup-integration-api dependency at line 145. All version changes maintain consistency with the overall PR objective.
Also applies to: 89-90
mosip-identity-plugin/pom.xml (1)
89-90: Version bumps are synchronized across all modules.The esignet and esignet-signup version properties are updated consistently with the other plugin modules. Dependencies correctly reference these properties (esignet-core, esignet-integration-api, and signup-integration-api).
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.