Refactor and improvements #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce indentation.
kh31d4r
had a problem deploying
to
github-pages
GitHub Actions
Failure
For compatibility with systems that don't use "/" as path delimiter.
Since it is IRC specific, and the IRC server is dead, at least for now.
They make for more readable keys instead of strings containing numbers, especially since they did not start with index 0.
Structure the data instead of having multiple separate dicts with the same keys.
Introduce some depth into the datastructure instead of having multiple separate dictionaries with prefixes in the keys.
kh31d4r
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structure the data in strings.json properly, and fix some minor portability issues and random cleanup.