Skip to content

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 10, 2025

PYTHON-5673

Changes in this PR

Prevent pyproject.toml changes from triggering an SBOM update PR, since there are no direct dependencies defined in pyproject.toml. We are covered by the requirements.txt file. This prevents spurious PRs like #2645.

Test Plan

N/A

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@blink1073 blink1073 requested a review from a team as a code owner December 10, 2025 21:55
@aclark4life
Copy link
Contributor

Does that mean we can remove pyproject.toml over here (assuming we leave dependencies in requirements.txt) ?

@blink1073
Copy link
Member Author

Does that mean we can remove pyproject.toml mongodb/django-mongodb-backend#451 (comment) we leave dependencies in requirements.txt) ?

I'd say yes, since the backend uses the same pattern. Otherwise you'd get a PR for updating a lint rule.

Copy link
Contributor

@aclark4life aclark4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit da6d3d9 into mongodb:master Dec 11, 2025
78 of 80 checks passed
@blink1073 blink1073 deleted the PYTHON-5673 branch December 11, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants